Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include jars from fullClassPath if they aren't initially calculated #103

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Include jars from fullClassPath if they aren't initially calculated #103

wants to merge 1 commit into from

Conversation

mdedetrich
Copy link
Collaborator

@mdedetrich mdedetrich commented Jan 9, 2024 •
edited
Loading

Resolves: #102

Implements this solution

At least on a glance to me it seems like a quick way to fix this is to combine both (dependencyClasspathAsJars in Compile).value.map(.data) ++ (products in Compile).value and (fullClasspath in Compile) but use (dependencyClasspathAsJars in Compile).value.map(.data) ++ (products in Compile).value as a preference which should still solve the underlying problem described in #60 .

@mdedetrich mdedetrich marked this pull request as draft January 9, 2024 03:25
@mdedetrich mdedetrich force-pushed the include-jars-from-full-classpath-if-not-initially-existing branch from 0c79492 to 24f06bb Compare January 9, 2024 03:32
@mdedetrich
Copy link
Collaborator Author

So this PR is failing to pass because the scripted test test-05-exportJars is stalling. test-10-multi-project-dependsOn-includePackage-versions is passing since there aren't any extra jars in (fullClasspath in Compile) that isn't contained within (dependencyClasspathAsJars in Compile).value.map(.data) ++ (products in Compile).value

@mdedetrich
Copy link
Collaborator Author

Blocked by #104

@mdedetrich mdedetrich mentioned this pull request Jan 9, 2024
Open
@Roiocam Roiocam mentioned this pull request Jan 30, 2024
Closed
@mdedetrich mdedetrich mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix regression when using Jar's to force proper manifest files
1 participant
@mdedetrich