Be more defensive against zero prices

sboehler · Oct 7, 2024 · 26c30f0 · 26c30f0
1 parent 582e928
commit 26c30f0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/lib/journal/process.go b/lib/journal/process.go
@@ -25,8 +25,7 @@ func ComputePrices(v *model.Commodity) *Processor {
 	prc := make(price.Prices)
 	return &Processor{
 		Price: func(p *model.Price) error {
-			prc.Insert(p.Commodity, p.Price, p.Target)
-			return nil
+			return prc.Insert(p.Commodity, p.Price, p.Target)
 		},
 		DayEnd: func(d *Day) error {
 			if len(d.Prices) > 0 {

diff --git a/lib/model/price/prices.go b/lib/model/price/prices.go
@@ -31,9 +31,13 @@ type Prices map[*commodity.Commodity]NormalizedPrices
 var one = decimal.NewFromInt(1)
 
 // Insert inserts a new price.
-func (ps Prices) Insert(commodity *commodity.Commodity, price decimal.Decimal, target *commodity.Commodity) {
+func (ps Prices) Insert(commodity *commodity.Commodity, price decimal.Decimal, target *commodity.Commodity) error {
+	if price.IsZero() {
+		return fmt.Errorf("invalid price %s for commodity %s in %s", price.String(), commodity.Name(), target.Name())
+	}
 	ps.addPrice(target, commodity, price)
 	ps.addPrice(commodity, target, one.Div(price).Truncate(8))
+	return nil
 }
 
 func (ps Prices) addPrice(target, commodity *commodity.Commodity, price decimal.Decimal) {

diff --git a/lib/quotes/yahoo2/yahoo2.go b/lib/quotes/yahoo2/yahoo2.go
@@ -106,7 +106,9 @@ func decodeResponse(r io.Reader) ([]Quote, error) {
 			AdjClose: result.Indicators.Adjclose[0].Adjclose[i],
 			Volume:   result.Indicators.Quote[0].Volume[i],
 		}
-		res = append(res, q)
+		if q.Close > 0 {
+			res = append(res, q)
+		}
 	}
 	return res, nil
 }