Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest): automatic checks should not be triggered for failed tests #66

Open
mohanraj-r opened this issue Jun 21, 2021 · 0 comments
Open
Labels
enhancement New feature or request P1 Priority: High

Comments

@mohanraj-r
Copy link
Contributor

mohanraj-r commented Jun 21, 2021

  • Automatic check is triggered regardless of the test status which would result in the original test failure if any getting overwritten by a11y failures if any from automatic checks.

  • Tests using the sa11y jest api would get tested twice with automatic checks - once as part of the sa11y API in the test and again as part of the automatic check

    • a11y issues from automatic checks would overwrite the a11y issues found by the API
    • If the sa11y API has been added to the test to check specific intermediate states of the DOM, enabling automatic checks could result in missed a11y issues

Workarounds

Current

  • Enable automatic checks in a parallel CI workflow and not in the main CI workflow.

Future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Priority: High
Projects
None yet
Development

No branches or pull requests

1 participant