fix: icon placement in rtl layouts #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great this commit solved the issue i had |
|
ping @saket for reviewing 🤞 |
jocmp
added a commit
to jocmp/capyreader
that referenced
this pull request
Oct 20, 2024
jocmp
added a commit
to jocmp/capyreader
that referenced
this pull request
Oct 20, 2024
* Use 3rd-party swipe library * Fix RTL with open PR - saket/swipe#33
|
@saket bump, can u merge it? |
saket
approved these changes
Nov 21, 2024
saket
reviewed
Nov 21, 2024
| } | ||
| } | ||
| .background(color = backgroundColor), | ||
| horizontalArrangement = if (action.isOnRightSide) Arrangement.Start else Arrangement.End, | ||
| horizontalArrangement = if (action.isOnRightSide) Arrangement.Absolute.Left else Arrangement.Absolute.Right, |
There was a problem hiding this comment.
Let's add a screenshot test to verify this? Here are some examples: https://github.com/saket/swipe/blob/trunk/library/src/test/kotlin/me/saket/swipe/SwipeableActionsBoxTest.kt#L43
There was a problem hiding this comment.
Not sure if I did this correctly. Please take another look!
saket
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32
Context: The offsets from swipings are absolute, so the placement of icons should be as well