Add unchecked_disjoint_bitor per ACP373
#135760
Open
+172
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval |
3 tasks
TDecking
reviewed
Jan 20, 2025
| // For c1 to be set we need to have overflowed, but if we did then | ||
| // `a` is at most `MAX-1`, which means that `c2` cannot possibly | ||
| // overflow because it's adding at most `1` (since it came from `bool`) | ||
| (b, unsafe { intrinsics::disjoint_bitor(c1, c2) }) |
There was a problem hiding this comment.
The use of this intrinsic inside borrowing_sub is missing.
| @@ -167,6 +167,11 @@ pub trait BuilderMethods<'a, 'tcx>: | |||
| fn unchecked_umul(&mut self, lhs: Self::Value, rhs: Self::Value) -> Self::Value; | |||
| fn and(&mut self, lhs: Self::Value, rhs: Self::Value) -> Self::Value; | |||
| fn or(&mut self, lhs: Self::Value, rhs: Self::Value) -> Self::Value; | |||
| /// Defaults to [`Self::or`], but guarantees `(lhs & rhs) == 0` so some backends | |||
| /// can emit something more helpful for optimizations. | |||
| fn or_disjoint(&mut self, lhs: Self::Value, rhs: Self::Value) -> Self::Value { | |||
There was a problem hiding this comment.
Why is this a method and not just a normal intrinsic? Why does this have 2 default implementations? (fallback in core and default impl here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the names from libs-api in rust-lang/libs-team#373 (comment)
Includes a fallback implementation so this doesn't have to update cg_clif or cg_gcc, and overrides it in cg_llvm to use
or disjoint, which is available in LLVM 18 so hopefully we don't need any version checks.