Add multi-select mode for lists #1058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a multi-select mode for lists in which the current selection changes to be a cursor and pressing enter marks the item under the cursor as actually selected. DropDown is based on list so this should unblock adding a multi-select mode to DropDown's as well. Updates rivo#330 Signed-off-by: Sam Whited <sam@samwhited.com>
SamWhited
force-pushed
the
list_multi_select
branch
from
339debc to
699bc05
Compare
|
Something else I thought of after preparing this that I'd like to get your opinion on: for multi-select in drop down's we'll need a callback for when an option is unselected as well as selected. We could re-use |
|
Gentle ping; no rush of course, I know you're busy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a multi-select mode for lists in which the current selection changes to be a cursor and pressing enter marks the item under the cursor as actually selected.
DropDown is based on list so this should unblock adding a multi-select mode to DropDown's as well (I have a followup PR that I can submit for this if desired).
Updates #330