-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notes with colored="true" and dur="2" get rendered in without the note head color inversion (CMN) #3605
Comments
colored attribute is explicitly also meant for CMN as stated in the guidelines. |
How should it be rendered in CMN? Visual display of coloration is different in white and black notation, so the visual rendering in CMN should reflect the mensural source. When citing the guidelines, it would be helpful to provide a link to the relevant section. |
Colored should be also available on CMN according the the spec:
|
Actually I am using the coloration during the first step of a transcription workflow to match the source. The result of this first step is a diplomatic/facsimilar transcription of the source with surfaces/zones mapped to the manuscript. The next step applies semi-automatically some rules to assign proper duration to semibreves and do the measures division. The source is in "iberian white notation" (used during early baroque in Spain and Portugal) that unfortunately doesn't fit on any of the MEI mensural cases. This notation/coloration is used only in the ternary meter known as "compasillo" (and represented with a CZ more or less). By coloring a semibreve that should be perfect (according to some rules) it is forced to be imperfect and last 2 minimas instead of 3. Notice in the example above that when forcing a semibreve to be imperfect you not only color the semibreve itself but also the surrounding notes. On those, the coloring has no effect at all in terms of duration changes and was intended only as a visual clue for performers about the rythm "alteration" |
Thanks, so you are encoding in an intermediate format with performance durations interpreted later, and you use
Yes, that makes it difficult to encode diplomatic versions of 17th century music when there was a gradual switch from mensuration to CMN. At the Chopin Institute, we encode such music in CMN: https://polishscores.org/?id=16xx:1489&con=TsTp{80} where It is the human encoders job to figure that out, or they don't get paid :-) Original for this example from 1615: https://cyfrowe.mnk.pl/dlibra/publication/24235/edition/23926/content?ref=desc This example is uses mensural rhythms (imperfect cut-c is the same as modern notaiton, but 3/2 is a perfect mensuration that needs work converting to CMN), with colored notation with 3/2 being a notation for sesquialtera as well as barlines, ligatures, and ties across barlines (bottom of page 12). Here is a funny deperfecting: The MIDI playback for this example needs fixing since the 3/2 music needs to be sped up (I will have to fix that :-) And I see that @rettinghaus has already fix the coloring of half notes in PR #3606 (which will be merged into the |
Since your encoding doesn’t need the “semantic” meaning of colored, it would be better to use the filled /void encoding. This is definitely a bug, though, since the note head should be inverted. |
Exactly. Usually this diplomatic transcription has no real interest for anyone other than the 3 or 4 musicologists working around that music. However on a couple of projects I am working on some parts of the manuscripts are in bad conditions with ink bleed-through, corroded paper and all the usual suspects. So every time I have to go back to the original implies a lot of time spent "deciphering" again the obscure parts. This is why I want to keep around this diplomatic transcription: a clean version of the manuscript to use during the later during the editing process.
Oh, no problem with that. Only white notes on CZ, so semiminim are like white quavers :). It's kind of funny when the same piece has a 4/4 or 4/2 section where suddenly black is black :) Thanks for the info and the links. Very nice ui and features!
Oh yeah, I also have some MIDI work pending... I have a local branch of verovio-app using js-synthesizer + libfluidsynth instead of wildwebmidi that I think it might be interesting for someone else. Let's see if I can find some time this weekend to clean and share it. |
but filled/void is not implemented, is it? |
That will be interesting to study as I have been too lazy to look for an alternate method to wildwestmidi since it works well enough. |
I started it with the hope of getting nicer vocal playbacks. You can listen to it in action here: https://humanoydivino.com/otros/livrodomingosmartins/ under folios 66 - 67 click on the button |
…otes_with_dur_2 Fix issue #3605: draw colored notes and dur="2" with empty note head
commit 2f0fed8 Merge: d7e0d9c a6355f4 Author: Andrew Hankinson <andrew.hankinson@gmail.com> Date: Tue May 7 14:44:31 2024 +0200 Merge pull request #3668 from musicEnfanthen/develop ci(gh-actions): include macos-14 in python wheel workflow (rebased) commit a6355f4 Author: musicEnfanthen <stefan.muennich@unibas.ch> Date: Tue May 7 14:41:37 2024 +0200 ci(gh-actions): include macos-14 in python wheel workflow (rebased) commit d7e0d9c Author: Andrew Hankinson <andrew.hankinson@gmail.com> Date: Tue May 7 11:01:43 2024 +0200 Tested GH actions This configuration has been tested and should work. commit a83cf81 Author: Laurent Pugin <lxpugin@gmail.com> Date: Wed May 1 12:34:16 2024 +0200 Update xcode versions commit 6aa2e96 Merge: ed140f4 8598527 Author: Laurent Pugin <lxpugin@gmail.com> Date: Wed May 1 11:33:47 2024 +0200 Merge pull request #3654 from rettinghaus/update-midi Update Midifile library commit ed140f4 Author: Laurent Pugin <lxpugin@gmail.com> Date: Wed May 1 08:28:11 2024 +0200 Rename io.h/cpp to iobase to avoid conflicts. Closes #3662 commit 8598527 Author: Klaus Rettinghaus <klaus.rettinghaus@gmail.com> Date: Tue Apr 23 09:18:31 2024 +0200 update midifile commit da4bac4 Merge: 23b4e2d f6d5828 Author: Laurent Pugin <lxpugin@gmail.com> Date: Fri Apr 19 10:48:53 2024 +0200 Merge pull request #3648 from rettinghaus/fix-dynam-extender only draw extender if set explicitly commit f6d5828 Author: Klaus Rettinghaus <klaus.rettinghaus@gmail.com> Date: Mon Apr 15 09:45:15 2024 +0200 only draw extender if set explicitly commit 23b4e2d Merge: fa32d17 ff4649d Author: Laurent Pugin <lxpugin@gmail.com> Date: Tue Apr 9 10:45:59 2024 +0200 Merge pull request #3644 from DavidBauer1984/fix/zip-file-reader Improve ZipFileReader commit ff4649d Author: David Bauer <davidbauer.frg@gmail.com> Date: Mon Apr 8 21:15:06 2024 +0200 Fix HasFile implementation commit fa32d17 Merge: 24c3b85 b541da8 Author: Laurent Pugin <lxpugin@gmail.com> Date: Sat Mar 23 13:47:49 2024 +0100 Merge pull request #3636 from rettinghaus/update-clang-action Update clang-format-action commit 24c3b85 Merge: c0e4854 0f834f1 Author: Laurent Pugin <lxpugin@gmail.com> Date: Sat Mar 23 10:45:58 2024 +0100 Merge pull request #3628 from rettinghaus/fix/xmltied [skip-ci] fix ties from Dorico commit c0e4854 Merge: baeeaef 478a7c7 Author: Laurent Pugin <lxpugin@gmail.com> Date: Sat Mar 23 10:42:52 2024 +0100 Merge pull request #3630 from DavidBauer1984/setlocale Set locale once in toolkit commit b541da8 Author: Klaus Rettinghaus <klaus.rettinghaus@gmail.com> Date: Fri Mar 22 10:34:33 2024 +0100 formatting commit 2473700 Author: Klaus Rettinghaus <klaus.rettinghaus@gmail.com> Date: Fri Mar 22 10:30:37 2024 +0100 Update clang-format-check.yml commit 478a7c7 Author: David Bauer <davidbauer.frg@gmail.com> Date: Thu Mar 21 18:24:35 2024 +0100 Add proper methods and apply option in CLI commit ce8273d Author: David Bauer <davidbauer.frg@gmail.com> Date: Thu Mar 21 16:30:44 2024 +0100 Add option --set-locale commit 2a8f0b0 Author: David Bauer <davidbauer.frg@gmail.com> Date: Thu Mar 21 14:51:17 2024 +0100 Set locale in toolkit commit baeeaef Merge: 6a790ff f55d7bd Author: Andrew Hankinson <andrew.hankinson@gmail.com> Date: Thu Mar 21 14:01:01 2024 +0100 Merge pull request #3629 from rism-digital/dependabot/pip/fonts/black-24.3.0 Bump black from 22.12.0 to 24.3.0 in /fonts commit f55d7bd Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Mar 20 16:45:18 2024 +0000 Bump black from 22.12.0 to 24.3.0 in /fonts Bumps [black](https://github.com/psf/black) from 22.12.0 to 24.3.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.12.0...24.3.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> commit 0f834f1 Author: Klaus Rettinghaus <klaus.rettinghaus@gmail.com> Date: Wed Mar 20 10:32:01 2024 +0100 iterate over node set commit 057ce1c Author: Klaus Rettinghaus <klaus.rettinghaus@gmail.com> Date: Tue Mar 19 18:23:52 2024 +0100 fix ties from Dorico commit 6a790ff Author: Laurent Pugin <lxpugin@gmail.com> Date: Sun Mar 17 18:29:36 2024 +0100 Update Verovio.podspec to c++20 [skip-ci] commit 9f5d68f Merge: 3a14994 267c023 Author: Laurent Pugin <lxpugin@gmail.com> Date: Tue Mar 12 13:46:16 2024 +0100 Merge pull request #3621 from rism-digital/generic-pae-duration Refactor PAE Duration handling commit 267c023 Author: Andrew Hankinson <andrew.hankinson@gmail.com> Date: Tue Mar 12 12:00:13 2024 +0100 Update src/iopae.cpp Co-authored-by: Laurent Pugin <lxpugin@gmail.com> commit 3a14994 Merge: 24dd9de 38747a8 Author: Laurent Pugin <lxpugin@gmail.com> Date: Tue Mar 12 09:07:15 2024 +0100 Merge pull request #3617 from Matthew-w56/fix-delete-editing Added ClearCoords call when editing a beam commit 24dd9de Merge: 36a50ed b0092bf Author: Laurent Pugin <lxpugin@gmail.com> Date: Tue Mar 12 08:47:07 2024 +0100 Merge pull request #3623 from fernandoherreradelasheras/fix_midi_lyrics_on_quarter_notes Fix issue #3622: wrong lyrics position in midi output for <syl> in notes <= quarter commit b0092bf Author: Fernando Herrera <fherrera@onirica.com> Date: Mon Mar 11 22:59:11 2024 +0100 Fix lyrics position in midi output for <syl> in notes <= quarter commit 67da74a Author: Andrew Hankinson <andrew.hankinson@gmail.com> Date: Mon Mar 11 17:43:30 2024 +0100 Formatting commit 8f2e4ec Author: Andrew Hankinson <andrew.hankinson@gmail.com> Date: Mon Mar 11 17:36:34 2024 +0100 Refactor PAE Duration handling This change extracts the PAE duration handling into a static method that can be used to convert durations to their PAE representations. It also adds a new feature to the feature extractor that includes the note duration on the PAE note. commit 38747a8 Merge: f5c2e3e 633158f Author: Matthew Williams <mbwilliams785@gmail.com> Date: Thu Mar 7 09:19:38 2024 -0700 Merge branch 'fix-delete-editing' of https://github.com/Matthew-w56/verovio into fix-delete-editing commit f5c2e3e Author: Matthew Williams <mbwilliams785@gmail.com> Date: Thu Mar 7 09:19:27 2024 -0700 Reset interface variable name commit 36a50ed Merge: b7d4d7b 653fab8 Author: Laurent Pugin <lxpugin@gmail.com> Date: Thu Mar 7 07:27:40 2024 +0100 Merge pull request #3606 from fernandoherreradelasheras/fix_colored_notes_with_dur_2 Fix issue #3605: draw colored notes and dur="2" with empty note head commit 633158f Author: Matthew Williams <mbwilliams785@gmail.com> Date: Wed Mar 6 16:32:38 2024 -0700 final clang push commit 31178e0 Author: Matthew Williams <mbwilliams785@gmail.com> Date: Wed Mar 6 16:08:08 2024 -0700 Fixed clang problem commit a5e4e80 Author: Matthew Williams <mbwilliams785@gmail.com> Date: Wed Mar 6 15:59:23 2024 -0700 fixed known clang issues commit 2c669be Author: Matthew Williams <mbwilliams785@gmail.com> Date: Wed Mar 6 15:53:35 2024 -0700 fixed indentation commit bd1e3c7 Author: Matthew Williams <mbwilliams785@gmail.com> Date: Wed Mar 6 15:47:57 2024 -0700 Adjusted to meet some existing comments commit e1415cb Author: Matthew Williams <mbwilliams785@gmail.com> Date: Wed Mar 6 13:09:05 2024 -0700 Added ClearCoords call when editing a beam commit 653fab8 Author: Fernando Herrera <fherrera@onirica.com> Date: Wed Mar 6 18:15:29 2024 +0100 Fix issue #3605: draw colored notes and dur="2" with empty note head commit b7d4d7b Merge: 05b1072 b2f9dc7 Author: Laurent Pugin <lxpugin@gmail.com> Date: Mon Mar 4 07:41:41 2024 +0100 Merge pull request #3615 from andre2007/c_functions Add toolkit functions to c_wrapper commit b2f9dc7 Author: Andre Pany <andre@s-e-a-p.de> Date: Sun Mar 3 21:11:08 2024 +0100 Add toolkit functions to c_wrapper commit 05b1072 Author: Laurent Pugin <lxpugin@gmail.com> Date: Thu Feb 29 09:51:45 2024 +0100 Remove the C binding directory [skip-ci] * Now documented in https://book.verovio.org/installing-or-building-from-sources/library.html commit 6f72343 Author: Laurent Pugin <lxpugin@gmail.com> Date: Thu Feb 29 09:50:06 2024 +0100 Update README.md for Qt [skip-ci] commit 4055bc7 Author: Laurent Pugin <lxpugin@gmail.com> Date: Thu Feb 29 09:48:44 2024 +0100 Update README.md for Android [skip-ci] commit c708a89 Author: Laurent Pugin <lxpugin@gmail.com> Date: Thu Feb 29 09:01:02 2024 +0100 Add c_wrapper.h to the library headers [skip-ci] commit 34eeaf6 Merge: 46bc577 10c6ef3 Author: Laurent Pugin <lxpugin@gmail.com> Date: Thu Feb 29 07:35:16 2024 +0100 Merge pull request #3611 from ammatwain/develop Update vrv.cpp commit 10c6ef3 Author: Amedeo Sorpreso <amedeo@sorpreso.it> Date: Wed Feb 28 16:59:39 2024 +0100 Update vrv.cpp To ensure correct code formatting for floating-point values, two lines of code have been added to the "StringFormat" method, temporarily resetting the compiler's std::locale configurations. This prevents formatting issues stemming from specific OS or development environment settings, ensuring consistent and accurate numerical representation in the C++ source code during program execution. (At least, they do on my machine; I hope it's the same on yours... :) ) commit 46bc577 Merge: f8f4c11 38c4429 Author: Laurent Pugin <lxpugin@gmail.com> Date: Wed Feb 28 14:28:10 2024 +0100 Merge branch 'develop' of https://github.com/rism-digital/verovio into develop commit f8f4c11 Author: Laurent Pugin <lxpugin@gmail.com> Date: Wed Feb 28 14:27:59 2024 +0100 Add cmake instruction for copying header files commit 38c4429 Merge: 43e44f8 3260a7c Author: Laurent Pugin <lxpugin@gmail.com> Date: Wed Feb 28 13:33:53 2024 +0100 Merge pull request #3609 from andre2007/develop [skip-ci] Include info how to build verovio.dll on Windows using MS Build Tools commit 3260a7c Author: andre2007 <andre@s-e-a-p.de> Date: Tue Feb 27 20:41:16 2024 +0100 Include info how to build verovio.dll on Windows using MS Build Tools commit 43e44f8 Author: Laurent Pugin <lxpugin@gmail.com> Date: Tue Feb 27 18:38:18 2024 +0100 add CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS [skip-ci] commit cdd3b0d Author: Laurent Pugin <lxpugin@gmail.com> Date: Mon Feb 26 14:37:59 2024 +0100 Add library installation paths [skip-ci] commit 4b90478 Merge: 383dcaf 00a53e5 Author: Laurent Pugin <lxpugin@gmail.com> Date: Mon Feb 26 10:38:29 2024 +0100 Merge pull request #3607 from rettinghaus/fonts fonts update with filled half note commit 00a53e5 Author: Klaus Rettinghaus <klaus.rettinghaus@gmail.com> Date: Sat Feb 24 22:54:52 2024 +0100 add filled half note commit 383dcaf Author: Laurent Pugin <lxpugin@gmail.com> Date: Tue Feb 20 15:56:36 2024 +0100 Write fermata for rest and mRest in PAE output commit 7ce8b6d Author: Laurent Pugin <lxpugin@gmail.com> Date: Tue Feb 20 15:54:07 2024 +0100 Add PAEOutput::HasFermata helper commit 7e54f75 Author: Laurent Pugin <lxpugin@gmail.com> Date: Tue Feb 20 15:51:01 2024 +0100 Fix missing parameter in JS proxy commit 75efb61 Merge: ae00a34 e1f3a07 Author: Laurent Pugin <lxpugin@gmail.com> Date: Mon Feb 19 09:21:12 2024 +0100 Merge pull request #3599 from rettinghaus/devlop/restbeam Import breaksec on rests from MusicXML [skip-ci] commit ae00a34 Merge: 105641f 5757ff9 Author: Laurent Pugin <lxpugin@gmail.com> Date: Mon Feb 19 09:18:26 2024 +0100 Merge pull request #3601 from rettinghaus/fix-tabNote fix doubled g in SVG commit 5757ff9 Author: Klaus Rettinghaus <klaus.rettinghaus@gmail.com> Date: Fri Feb 16 12:54:01 2024 +0100 fix doubled graphic commit e1f3a07 Author: Klaus Rettinghaus <klaus.rettinghaus@gmail.com> Date: Fri Feb 16 10:25:30 2024 +0100 import breaksec commit 105641f Author: Laurent Pugin <lxpugin@gmail.com> Date: Fri Feb 9 13:03:14 2024 +0100 Set macos deployment target [skip-ci]
in CMN colored="true" is reflected by inverting the note head fill / void. This works fine for all note durations but for dur="2" that remains as a normal half note (and it should look like a quarter note).
See the following MEI:
currently renders to:
and it should be:
The text was updated successfully, but these errors were encountered: