-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable admins to view all resources on the status page #6489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support `filters: enable:` in the canvas YAML * Set to true by default
…elled mid way (#6494) * version can leak if mutate errors in between * also fix create
Updated the bottom section to refer to metrics views rather than rill.yaml and dashboards
* feat: add quick actions for pivot * fix: lint * fix: add tooltips and adjust delay * fix: column event handler
begelundmuller
requested changes
Jan 27, 2025
* fix: embedded dashboards without time series * tweak * attempt to fix test
* Add VL config tab, cosmetic changes * Use deepmerge for merging configs * Split multi and single select field input * Add dot menu for chart fields * Center align KPI content * Add default title to charts * Remove optional labels * Fix bug in multi select * KPI sparkline fainter, add plus to diff * Remove whitespace before percent symbol * Add canvas filters store * Move state out of granular filter components * Add canvas filters UI * Add support for multi metrics view for a common filer * Add method for fetching multiple metrics dimensions * Use new canvas resolver api * Initial time controls integration * Add new keys to canvas panel, update styles * Create class and readables for valid spec * Add loading state from spec store * Style as per mock * Move dimension/measure selectors to spec class * Move timefilterstore as a method to canvas entity * Move all selectors to canvas spec * Review * Fix bug in all time store * Fix stale cache issues * Add measure dimension to metrics map * Measure filter for multiple metrics * Add dimensions for measure filter * support multiple metrics view in dimension filter chip * Cleanup * Change label for one color * Add tooltips style to default tooltip id * Simplify chart specs * Use canvas instead of svg for viz * Add formating to tooltips * format axis * cleanup * Use field as formatter name * Support time dimension in chart * Add stacked area chart * Add dimension filter to panel UI * Read filter from YAML * Remove unused var * Wrap parsed expression * Avoid overwriting on other component * Use component filter for KPI and charts * Add note for table * Toggle filter bar visibility * Make dimension chip smaller * Lint fix * Use canvas store for table component * Add validator to spec * Use cross instead of minus for multi input * Add alignment input to markdown * Remove hardcoded values * Remove unused selectors * Validate schema for KPI * Cleaner selectors for KPI * Add validation to charts * Lint fix * Remove leftover comment * Increase health check concurrency to 32 (#6488) * fix : db file does not get deleted if mutate/rename gets errored/cancelled mid way (#6494) * version can leak if mutate errors in between * also fix create * Increase timeout for graceful controller shutdown to 30s (#6500) * remove referenced columns, gap * row based component addition, change default size * fix find available pos logic, default size tweaks, select new component index * wip * disallow dragging in grid * comment out resize handle * drag n drop, w/ ghost line * fix regression * data selected style * ability to drag to new row * remove local z index * clean up * clean up * simplify handle drop with helpers * check if dragged item is full width when dropping in bottom pos * wip * open inspector when a canvas item is selected * null check and clean up in sliding words * tweak other components' default size * removed, in favor of group items by row * scroll into view after adding new component * add more data-attributes * data-row-index, data-column-index * remove resize handle * compact grid upon item removal * left aligned on deletion * left align when drag and drop * add drag handle * fix handledrop with bottom, left, right * update selected index to follow the dropped item * types * move helpers to util * only allowed to drag around when dragging draghandle * tweak padding, pos of drag handle * GhostLine to DropTargetLine * data-hovered in Component * shadow tweak * tweak drag handle * layout shift border fix when selected * row container * wip * comments * fixme * wip * nit * fix drop target line, drop position * rebase fix * rebase fix * use new items when dispatching update * row resize handle * resize row height polish * nit * enforce resizing row cursor * col resize handle * spread components evenly * update yaml after deleting * col resize improvement * add a placeholder component min width when resizing col * redistribute when adding * clean up * clean up * disable redistributing when adding component * embed to disable interactivity * remove top pos usage * disable redistribute in deleteComponent * lint * fix drop targets * Revert "fix drop targets" This reverts commit a87bddf. * clean up * row to top * use transform for positioning * items dropping fix, clean up * types, open inspector * nit * spread evenly on click * floating button group * row resizer * column resizer * clean up * empty state items * cherry pick fix * skip test * lint * visual tweaks * visual tweaks * rebase fixes * white bg in blank canvas * context menu add component initial * chart icon in blank menu items * other menu canva icons * add component to blank canvas * icons to add component menu * move blank canvas one level down * move addComponent to canvas, wip * wip * wip * reset canvas new file gen, wip * rebase fix * lint * rebase fix * clean up * remove intrinsic padding of component, preview el * blank state box shadow * tweak row resizer placement, no physical space until hover * color change on row resizer * col resizer tweaks * undo canvas filters comment * handle drops into empty spaces * clean up * revert * remove scale * undo drag handle in embed * revert * rename * comment out col, row resizer, focus on layout * use card styles from figma * comment out custom dnd * comment out unused * initialize gridstack * add embed to gridstack * workaround for spec gapx and gapy in gridstack margin * pass spec to embed * gap tweaks * use original set doc when adding new component * readd filters to preview * clean up * tick to wait for dom changes, avoid racy * use data-index when dragging/resizing * move filters to canvas, visual checks * dynamic column count for smaller screen handle * lint * lint * lint * deselect event from gridstack * use default dashword width * clean up * improve deselect, click inside canvas but outside of grid stack * left click to open contextmenu in blank canvas * style tweaks * remove test * fix possible racy when updating grid on drag * lint * selection style * remove old files * clean up util * major dev clean up, reset component defaultSize * lint * further improve canvas selection * enhance single column mode * defaultSize tweaks * improve canvas selection one more time * Revert "improve canvas selection one more time" This reverts commit 984a979. * keep sidebar config selection, improve deselect * rebase fixes * fix * Revert "keep sidebar config selection, improve deselect" This reverts commit 29dc031. * lint * lint * remove log * fixes * clean up * const gridstack options * use data-index for scroll to * fix * fixes * lint * feedback --------- Co-authored-by: Dhiraj Kumar <sumankumaribarnwal@gmail.com> Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com> Co-authored-by: Anshul Khandelwal <12948312+k-anshul@users.noreply.github.com>
* feat: project initialization tests * revert changes
begelundmuller
requested changes
Jan 29, 2025
* more disk leaks fixes * review comments - always keep current snapshot around * review comments - always keep current snapshot around * Update runtime/pkg/rduckdb/catalog.go Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com> --------- Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
* don't delete projects if github installation is removed * lint fixes * lint fixes
* override max date in public url form * revert * feedback
* Fix anchor arithmatic being truncated * Fix invalid firstMonth in timeutil.Truncate * Fix lint * Add absolute at modifier time support
* Create 0.54.md * Update 0.54.md * Not many commits to 0.54 from 53 * docs: add features * fix: nits --------- Co-authored-by: royendo <67675319+royendo@users.noreply.github.com>
* do not project deletes when github installation is suspended * do not project deletes when github installation is suspended
…dden (#6520) * Add requiredMeasures to explore fields * Do not send referenced measures for non-window measures * Fix windowed measures * Fix lint+tests * Refactor filter method * Change function name
* fix: checkbox indicator lag * restore binding
* Show custom logo in UI * Fix lint * Move query options to selectors * fix: padding and remove hover bg (#6544) * Fix lint --------- Co-authored-by: Alexander Thor <alec.karlsson@gmail.com>
…oading data as parquet files (#6548)
* fix typo * add logs * add org id
* chore: class cleanup * add background class
* do not log cancellation errors in worked jobs * some more log changes
begelundmuller
requested changes
Feb 3, 2025
* Basic FileInput * Add error state * Add drag-drop support * Add drop-over state and loading state * Fix lint * Add preview
* Basic FileInput * Add error state * Add drag-drop support * Add drop-over state and loading state * Fix lint * Support showing of custom logo * Add remove support in UI * Fix upload * Add preview * Imrpove preview
* selected component index null directly * inline add component * fix spacing * granular events handling for triggering contextmenu * shared menu items * remove dup contextmenu in blank canvas * remove add component menu * lint * remove unused * re-add ml-2 to canvas filters * Revert "remove add component menu" This reverts commit d7a1765. * add component
…ill into gplata/admin-status-page-1129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables admins to view all resources on the status page. This will better help administrators diagnose and triage resources within their projects.