Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor block validation logic - effects #3808

Draft
wants to merge 35 commits into
base: dev
Choose a base branch
from
Draft

Refactor block validation logic - effects #3808

wants to merge 35 commits into from
+607 −600

Conversation

stanislavlyalin
Copy link
Collaborator

Overview

Notes

Please make sure that this PR:

Bors cheat-sheet:

  • bors r+ runs integration tests and merges the PR (if it's approved),
  • bors try runs integration tests for the PR,
  • bors delegate+ enables non-maintainer PR authors to run the above.

@stanislavlyalin
blockSignature function moved to BlockValidationLogic
f541f9a
@stanislavlyalin
formatOfFields function moved to BlockValidationLogic
179a7b5
@stanislavlyalin
version function moved to BlockValidationLogic
ee167f4
@stanislavlyalin
futureTransaction function moved to BlockValidationLogic
41176d5
@stanislavlyalin
transactionExpiration function moved to BlockValidationLogic
c8d471c
@stanislavlyalin
deploysShardIdentifier function moved to BlockValidationLogic
cc5dfef
@stanislavlyalin
blockHash function moved to BlockValidationLogic
beebdee
@stanislavlyalin
Removed unused
5972692
@stanislavlyalin
phloPrice function moved to BlockValidationLogic
c1a1116
@stanislavlyalin
Rearranged validation functions
0417ab5
@stanislavlyalin
Version validation test moved to BlockValidationLogicSpec
be920f5
@stanislavlyalin
Block hash validation test moved to BlockValidationLogicSpec
0af307a
@stanislavlyalin
Block fields validation test moved to BlockValidationLogicSpec
31cd7dc
@stanislavlyalin
Block signature validation tests moved to BlockValidationLogicSpec
19f56a4
@stanislavlyalin
Future deploy validation tests moved to BlockValidationLogicSpec
6b5dc7f
@stanislavlyalin
Deploy expiration validation tests moved to BlockValidationLogicSpec
95e4a12
@stanislavlyalin
Internal function ignore marked private
48a557e
@stanislavlyalin
Fixed test name
962b06a
@stanislavlyalin
Simplified validation functions. They returns just Boolean
91a6f8e
@stanislavlyalin
Fixed calling validation functions. Added related tests
9194775
@stanislavlyalin
Test for formatOfFields made generative
e345109
@stanislavlyalin
Test for block signature made generative
9f5a5a8
@stanislavlyalin
Test for future deploy made generative
d5b040d
@stanislavlyalin
Fixed review issue: f evaluated always, errorStatus only if f r…
2f63371 
…eturns true
@stanislavlyalin
Tests for block's signature algorithm made generative
ddf248c
@stanislavlyalin
Refactored first test of ValidateTest with MonixTaskTest and Mockito.…
1375491 
… Other tests ignored for now
@stanislavlyalin
Refactored two more tests
29eb860
@stanislavlyalin stanislavlyalin self-assigned this Aug 24, 2022
@stanislavlyalin stanislavlyalin linked an issue Aug 24, 2022 that may be closed by this pull request
Refactor block validation logic #3774
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stanislavlyalin stanislavlyalin

Labels
bug-fix enhancement
Projects
None yet
Milestone
Block merge (Hard Fork 2)
Development

Successfully merging this pull request may close these issues.

Refactor block validation logic
1 participant
@stanislavlyalin