-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flake8 plugins custom errors are not supported #6
Comments
I end up with a simple solution via flake8
PS. I tried to use |
Thank your for your suggestions! The annotations are generated by Githubs own annotator. Searching for warnings/errors is configured via regex in a static configuration file for the problemMatcher. It would very well be possible to include further annotations generated by flake8 plugins. If it's fine to classify additional plugins output as warnings only, I would prefer the second option, otherwise plugin outputs have to be categorized in warning and error level each. But it's definitely doable. |
Some plugins use long prefixes, for example, ANN001 in https://pypi.org/project/flake8-annotations/ |
In the CI context, I prefer to treat anything reported by flake8 as errors. If something is reported it should be fixed, suppressed, or disabled. It does not matter for me which annotation will highlight these errors. |
I tried coping the two problem-matcher.json files to my local .github and editing to include 'D' in the warning regex to add docstring violations to the annotations, but it does not appear to have worked. I'm a new two github actions---it there something else I have to reference to change this functionality? |
If figured out that if I add to my workflow
and those files are in my .github directory, it runs correctly. The files can then be edited. |
See rbialon#6 Adds support for flake8-annotations, flake8-bandit, flake8-docstrings and flake8-import-order
I use flake8 plugins and they produce output that is not parsed by actions.
Thye use own letters for messages
D : flake8-docstrings==1.5.0
I: flake8-import-order==0.18.1
B: flake8-bandit==2.1.2
Here is an example:
I would like them to be annotated too.
I will just put some idea, I don't know if they are implementable:
@v1
- >@x2
The alternative solution is to write a new plugin for flake8 that will change the output. Like a plugin for TeamCity CI.
My use case is not very common, so
won't fix
is an option too.The text was updated successfully, but these errors were encountered: