Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service account setup instructions #225

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Update service account setup instructions #225

merged 1 commit into from
Jun 30, 2024

Conversation

lacop11
Copy link
Contributor

@lacop11 lacop11 commented Jun 26, 2024

Fixes #224:

@lacop11
Update service account setup instructions
84e3415 
Fixes #224:
- Don't recommend giving "owner" to the service account, in fact no permissions are necessary.
- Show how to use workload identity instead of storing the JSON key in the project (credit to @StuClift in #146).
- Clean up formatting.
- Link relevant docs.
@lacop11
Copy link
Contributor Author

lacop11 commented Jun 27, 2024

@boswelja

(No rush, just making sure you are aware & I can't assign you)

boswelja
boswelja approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@boswelja boswelja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me 👍

@boswelja boswelja merged commit 30d77d4 into r0adkll:master Jun 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boswelja boswelja boswelja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessive permissions recommended?
2 participants
@lacop11 @boswelja