Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX :: Datacube variance should be squared, not cubed #1883

Merged
merged 3 commits into from
Dec 19, 2024
Merged

HOTFIX :: Datacube variance should be squared, not cubed #1883

merged 3 commits into from
Dec 19, 2024

Conversation

rcooke-ast
Copy link
Collaborator

As pointed out by @jhennawi, the cubed term is likely wrong, and has been changed to a squared term. This checks out based on some simple checks.

@rcooke-ast rcooke-ast requested a review from jhennawi December 18, 2024 21:44
kbwestfall
kbwestfall approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without digging too deeply, this looks right to me.

profxj
profxj approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to approve

jhennawi
jhennawi approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@jhennawi jhennawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rcooke-ast

@jhennawi jhennawi merged commit 016fc30 into develop Dec 19, 2024
26 checks passed
@rcooke-ast rcooke-ast deleted the hotfix_cubevar branch December 19, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbwestfall kbwestfall kbwestfall approved these changes

@jhennawi jhennawi jhennawi approved these changes

@profxj profxj profxj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rcooke-ast @profxj @jhennawi @kbwestfall