Skip to content

Commit

Permalink
chore: bump workflow node version to 20 (#4034)
Browse files Browse the repository at this point in the history
* chore: bump workflow node version to 20

`lru-cache` has dropped support for Node 18, and now requires Node 20 or
higher.

When `projen` creates new projects that use jest, those pull in
`lru-cache` using the following dependency path:

```
jest > @jest/core > @jest/transform > @babel/core > @babel/helper-compilation-targets > lru-cache
```

That happens to install the newest `lru-cache` version, which no longer
works on Node 18, and so our tests fail.

Bump our workflow Node to 20 to at least make our PR build pass again.

I don't know if this should have bearing on projen's minimum node
version; I suppose *technically* not, and people with a working
`package-lock` will be unaffected... but it might be hard to explain the
intricacies to users.

* Need 20.9.0
  • Loading branch information
rix0rrr authored Jan 9, 2025
1 parent 10391cf commit c275f5f
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 14 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions .github/workflows/release.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/upgrade-bundled-main.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/upgrade-main.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ const project = new JsiiProject({
projenDevDependency: false, // because I am projen
releaseToNpm: true,
minNodeVersion: "16.0.0", // Do not change this before a version has been EOL for a while
workflowNodeVersion: "18.18.0",
workflowNodeVersion: "20.9.0",

codeCov: true,
prettier: true,
Expand Down

0 comments on commit c275f5f

Please sign in to comment.