Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apex] Update apex-parser and summit-ast #5327

Merged
merged 7 commits into from
Jan 24, 2025
Merged

[apex] Update apex-parser and summit-ast #5327

merged 7 commits into from
Jan 24, 2025

Conversation

adangel
Copy link
Member

@adangel adangel commented Nov 14, 2024 •
edited
Loading

Describe the PR

  • Bump apex-parser from 4.3.0 to 4.4.0
  • Bump summit-ast from 2.3.0 to 2.4.0

See

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Nov 14, 2024
@adangel adangel added this to the 7.8.0 milestone Nov 14, 2024
@adangel
Copy link
Member Author

adangel commented Nov 14, 2024

Puhhh... unfortunately this update is not compatible and requires a new Summit-AST first:

  java.lang.NoSuchMethodError: 'java.util.List io.github.apexdevtools.apexparser.ApexParser$WhenValueContext.id()'
  	at com.google.summit.translation.Translate.visitWhenControl(Translate.kt:879)
  	at com.google.summit.translation.Translate.visitSwitchStatement(Translate.kt:1750)
  	at com.google.summit.translation.Translate.visitSwitchStatement(Translate.kt:106)
  	at io.github.apexdevtools.apexparser.ApexParser$SwitchStatementContext.accept(ApexParser.java:4346)
  	at org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visit(AbstractParseTreeVisitor.java:18)
  	at com.google.summit.translation.Translate.visitStatement(Translate.kt:1733)
  	at com.google.summit.translation.Translate.visitBlock(Translate.kt:786)
  	at com.google.summit.translation.Translate.visitMethodDeclaration(Translate.kt:480)
  	at com.google.summit.translation.Translate.visitMemberDeclaration(Translate.kt:440)
  	at com.google.summit.translation.Translate.visitClassBodyDeclaration(Translate.kt:399)
  	at com.google.summit.translation.Translate.visitClassBody(Translate.kt:391)
  	at com.google.summit.translation.Translate.visitClassDeclaration(Translate.kt:219)
  	at com.google.summit.translation.Translate.visitTypeDeclaration(Translate.kt:259)
  	at com.google.summit.translation.Translate.visitCompilationUnit(Translate.kt:158)
  	at com.google.summit.translation.Translate.translate(Translate.kt:121)
  	at com.google.summit.SummitAST.parseAndTranslate$_maven_lib(SummitAST.kt:153)
  	at com.google.summit.SummitAST.parseAndTranslate(SummitAST.kt:110)
  	at net.sourceforge.pmd.lang.apex.ast.ApexParser.parse(ApexParser.java:34)
  	at net.sourceforge.pmd.lang.apex.ast.ApexParser.parse(ApexParser.java:18)

@adangel adangel removed this from the 7.8.0 milestone Nov 14, 2024
@adangel adangel marked this pull request as draft November 14, 2024 15:44
@adangel adangel force-pushed the bump-apex-parser-4.3.1 branch from 18c5bdc to 345a0aa Compare November 22, 2024 16:20
@adangel
Copy link
Member Author

adangel commented Nov 22, 2024

I've verified locally that it works, after google/summit-ast#66 is used.

@adangel adangel force-pushed the bump-apex-parser-4.3.1 branch from 345a0aa to 610c28d Compare December 14, 2024 19:23
@adangel adangel changed the title Bump apex-parser from 4.3.0 to 4.3.1 Bump apex-parser from 4.3.0 to 4.4.0 Dec 14, 2024
@adangel
Copy link
Member Author

adangel commented Dec 14, 2024

Verified locally, that it builds after google/summit-ast#67 is used.

@adangel adangel mentioned this pull request Dec 17, 2024
Merged
2 tasks
This was referenced Jan 8, 2025
Closed
Closed
@adangel adangel added this to the 7.10.0 milestone Jan 14, 2025
@adangel adangel marked this pull request as ready for review January 14, 2025 17:55
@pmd-test
Copy link

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@adangel adangel removed dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 14, 2025
@adangel adangel changed the title Bump apex-parser from 4.3.0 to 4.4.0 Update apex-parser to 4.4.0 and summit-ast Jan 14, 2025
@adangel adangel changed the title Update apex-parser to 4.4.0 and summit-ast [apex] Update apex-parser to 4.4.0 and summit-ast Jan 14, 2025
@adangel adangel changed the title [apex] Update apex-parser to 4.4.0 and summit-ast [apex] Update apex-parser and summit-ast Jan 14, 2025
@adangel adangel merged commit d48bd41 into pmd:main Jan 24, 2025
3 checks passed
@adangel adangel deleted the bump-apex-parser-4.3.1 branch January 24, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.10.0
2 participants
@adangel @pmd-test