fix(typings): telegram.edit args correct types

fix Markup type (correct on context) arguments can be undefined but they should be explicitly This way you state explicitly what you want and dont forget something. This way typescript can actually help you BREAKING CHANGE: you have to supply undefined where you could ommit the argument before
plant7403 · Jun 2, 2020 · a8c6a34 · a8c6a34
1 parent 84d11f5
commit a8c6a34
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/typings/context.d.ts b/typings/context.d.ts
@@ -425,7 +425,7 @@ export declare class TelegrafContext {
    * @param markup Markup of inline keyboard
    */
   editMessageCaption(
-    caption?: string,
+    caption: string | undefined,
     markup?: tt.InlineKeyboardMarkup
   ): Promise<tt.Message | boolean>
 
@@ -435,7 +435,7 @@ export declare class TelegrafContext {
    * @param markup Markup of inline keyboard
    */
   editMessageReplyMarkup(
-    markup?: tt.InlineKeyboardMarkup
+    markup: tt.InlineKeyboardMarkup | undefined
   ): Promise<tt.Message | boolean>
 
   /**

diff --git a/typings/telegram.d.ts b/typings/telegram.d.ts
@@ -137,8 +137,8 @@ export declare class Telegram extends ApiClient {
     chatId: number | string | undefined,
     messageId: number | undefined,
     inlineMessageId: string | undefined,
-    caption: string,
-    markup: string
+    caption: string | undefined,
+    markup?: tt.InlineKeyboardMarkup
   ): Promise<tt.Message | boolean>
 
   /**
@@ -153,7 +153,7 @@ export declare class Telegram extends ApiClient {
     chatId: number | string | undefined,
     messageId: number | undefined,
     inlineMessageId: string | undefined,
-    markup: string
+    markup: tt.InlineKeyboardMarkup | undefined
   ): Promise<tt.Message | boolean>
 
   /**