-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS build system files fixes #4212
VS build system files fixes #4212
Conversation
LeonidGoltsblat
commented
Dec 11, 2024
•
edited
Loading
edited
- added some missing files to pjlib project
- added missing configuration to pjsystest project and pjproject-vs14.sln
- build tools set changed from v140 (VS2015) to v143 (VS2022)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need a cleaner patch that only contains the difference and doesn't mark the entire file as modified.
cleaned! git ls-files --eol *.vcxproj* |
Thanks. |
Looks okay to me, but since I rarely touch Windows, I'll leave the approval to @nanangizz and @trengginas . |
Tested with VS 2022 only, looks okay. |
Tested on VS2015 and VS2019 |
Both can build the lib? Any additional steps, e.g: changing the build tools set version to older/140, required? As I read somewhere that VS2015 cannot use build tool set 143 (which is set in the property sheet). |
For VS2019 and VS2015, change the To v140 |
Okay, perhaps it is better to also add info about how to set the property sheet to docs? |