Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS build system files fixes #4212

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

LeonidGoltsblat
Copy link
Contributor

@LeonidGoltsblat LeonidGoltsblat commented Dec 11, 2024

  • added some missing files to pjlib project
  • added missing configuration to pjsystest project and pjproject-vs14.sln
  • build tools set changed from v140 (VS2015) to v143 (VS2022)

Copy link
Member

@sauwming sauwming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a cleaner patch that only contains the difference and doesn't mark the entire file as modified.

@LeonidGoltsblat
Copy link
Contributor Author

LeonidGoltsblat commented Dec 12, 2024

cleaned!

git ls-files --eol *.vcxproj*
shows that the repository has mixed line endings in VS build system files
maybe it makes sense to add .gitattributes and run at least
git add --renormalize *.vcxproj*

@sauwming sauwming added this to the release-2.16 milestone Dec 13, 2024
@sauwming
Copy link
Member

cleaned!

git ls-files --eol .vcxproj shows that the repository has mixed line endings in VS build system files maybe it makes sense to add .gitattributes and run at least git add --renormalize .vcxproj

Thanks.
Yes, tidying up the line endings can be done in a separate PR (similar to #4154), and then put the revision in .git-blame-ignore-revs so it won't show up in git blame.

@sauwming
Copy link
Member

Looks okay to me, but since I rarely touch Windows, I'll leave the approval to @nanangizz and @trengginas .

@nanangizz
Copy link
Member

Tested with VS 2022 only, looks okay.
The docs says we support older VS versions (2015-2019), perhaps @trengginas can check.

@trengginas
Copy link
Member

Tested on VS2015 and VS2019

@nanangizz
Copy link
Member

Tested on VS2015 and VS2019

Both can build the lib? Any additional steps, e.g: changing the build tools set version to older/140, required? As I read somewhere that VS2015 cannot use build tool set 143 (which is set in the property sheet).

@trengginas
Copy link
Member

For VS2019 and VS2015, change the BuildToolset on pjproject-vs14-common-config.props

https://github.com/LeonidGoltsblat/pjproject/blob/31f8676c37847060da6ace988a160f2905b3f723/build/vs/pjproject-vs14-common-config.props#L26

To v140
Notes: for VS2019 it supports buildtoolset up to v142.

@nanangizz
Copy link
Member

For VS2019 and VS2015, change the BuildToolset on pjproject-vs14-common-config.props

https://github.com/LeonidGoltsblat/pjproject/blob/31f8676c37847060da6ace988a160f2905b3f723/build/vs/pjproject-vs14-common-config.props#L26

To v140 Notes: for VS2019 it supports buildtoolset up to v142.

Okay, perhaps it is better to also add info about how to set the property sheet to docs?

@sauwming sauwming self-requested a review December 18, 2024 07:30
@sauwming sauwming merged commit ea944b9 into pjsip:master Dec 18, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants