-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcaputil: Support parsing decoder options from FMTP input #4205
Conversation
It's rather strange to pass the entire SDP as a parameter. |
How do I parse it and set the params in |
https://github.com/pjsip/pjproject/blob/master/pjmedia/src/pjmedia/stream_common.c#L110 You can make it simpler by requiring the parameter to have no whitespace, so:
|
So do you want me to factor this out? What about passing this to the codec? Should I also factor out parts of |
What I mean is to add new parameter |
9ff932e
to
ac0cefa
Compare
ac0cefa
to
4c99091
Compare
Done, with a small refactoring. |
The failed test looks unrelated to my changes. @sauwming please review. |
Some codecs need specific flags that are given in the SDP media description. For example, AMR has octet-align=1. Instead of adding distinct flags for each codec, allow pcaputil to accept the fmtp content and parse the attributes from there. Example: pcaputil \ --dst-port=52422 \ --codec=AMR/8000 \ --codec-fmtp='mode-set=0,1,2,3,4,5,6,7;octet-align=1' \ amr.pcap amr.wav
4c99091
to
d20063d
Compare
pcaputil: Support parsing decoder options from FMTP input
Some codecs need specific flags that are given in the SDP media description. For example, AMR has octet-align=1.
Instead of adding distinct flags for each codec, allow pcaputil to accept the fmtp content and parse the attributes from there.
Example: