Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug in audio conference disconnection #4198

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fixed bug in audio conference disconnection #4198

merged 1 commit into from
Dec 6, 2024

Conversation

sauwming
Copy link
Member

@sauwming sauwming commented Dec 6, 2024

To fix #4196.

Related to #3928, the loops to disconnect multiple connections from audio ports (any->sink, or source->any) are incorrect due to the potentially changing listener array and its count.

        for (i=0; i<src_port->listener_cnt; ++i) {
            ...
            // But the listener count will decrease here, and its array will shift.
            op_disconnect_ports(conf, &op_prm);
        }

@sauwming sauwming requested a review from nanangizz December 6, 2024 07:20
@sauwming sauwming self-assigned this Dec 6, 2024
@sauwming sauwming added this to the release-2.16 milestone Dec 6, 2024
@sauwming sauwming merged commit 9030274 into master Dec 6, 2024
36 checks passed
@sauwming sauwming deleted the conf-disc branch December 6, 2024 08:35
nanangizz pushed a commit that referenced this pull request Dec 16, 2024
@sauwming @nanangizz
Fixed bug in audio conference disconnection (#4198)
09a187e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanangizz nanangizz nanangizz approved these changes

Assignees

@sauwming sauwming

Labels
component: pjmedia type: bug
Projects
None yet
Milestone
release 2.15.1
Development

Successfully merging this pull request may close these issues.

Audio streaming to audio sink does not stop after ending call
2 participants
@sauwming @nanangizz