Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unknown PSBT fields #118

Open
louisinger opened this issue Dec 31, 2024 · 3 comments · May be fixed by #119
Open

Support unknown PSBT fields #118

louisinger opened this issue Dec 31, 2024 · 3 comments · May be fixed by #119

Comments

@louisinger
Copy link

Unknown PSBT fields disappear when mergeKeyMap is executed. However, ark is using them to transport extra arguments to finalize complex inputs between users. It could also be useful to set musig2 PSBT fields before BIP373 is accepted.

From README:

We strip 'unknown' keys inside PSBT, they needed for new version/features support, however any unsupported feature/new version can significantly break assumptions about code. If you have use-case where they are needed, create a github issue.

What's required to support unknown PSBT keys ? What do you mean exactly by "break assumptions about code" ?
@louisinger louisinger linked a pull request Dec 31, 2024 that will close this issue
Open
@paulmillr
Copy link
Owner

Fingerprinting is an action when a wallet covertly adds some garbage info to tx that allows to identify its users on blockchain.

We need to ensure user transactions aren't fingerprintable. Your pull request will allow to make them fingerprintable by default.

@louisinger
Copy link
Author

Fingerprinting is an action when a wallet covertly adds some garbage info to tx that allows to identify its users on blockchain.

but PSBTs never hit the chain, so the garbage info will disappear when tx is extracted isn't it ?

@paulmillr
Copy link
Owner

It would still be possible to fingerprint some covert data from a cold wallet to hot wallet to track users.

I'm saying this needs a separate option and should not be on by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support unknown psbt keypairs louisinger/scure-btc-signer
2 participants
@paulmillr @louisinger