Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PQ-257] add ebollo configuration to checkout policy apim #2668

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aferracci
Copy link
Contributor

List of changes

Configured ebollo x-client-id on checkout apim policy.

Motivation and context

This change is necessary to properly manage the invocations coming from ebollo client to POST /carts api.

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

pasqualespica
pasqualespica previously approved these changes Dec 17, 2024
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasqualespica
Copy link
Contributor

@infantesimone @pietro-tota this change allows MDB project to use checkout/carts-auth as already done by the WISP dismantling prj

@@ -11,6 +11,11 @@
<value>WISP_REDIRECT</value>
</set-header>
</when>
<when condition="@(context.Subscription != null && context.Subscription.Id.ToLower().Equals("ebollo"))">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use otherwise, if there are exceptions or particular clients we will specify them. eBollo on ecommerce is tracked as CHECKOUT_CART

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@infantesimone as agreed the when block has been replaced with otherwise, there's no need to distinguish between ebollo payments and any other ones coming from EC.

cc @pietro-tota @pasqualespica

Copy link
Contributor

@pietro-tota pietro-tota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me but just one consideration:
this way we are not distinguishing ebollo transactions from EC carts transactions into monitoring dashboards (Kibana) nor b.e. side (payment methods, calculate fees, close payment, etc).

eCommerce side those transactions will be undistinguishable from an EC POST carts initiated ones.

My doubt here is if we have to trace those transactions differently for future ad hoc requirements/differentiations from the EC POST carts initiated transactions

cc @pagopa/pagopa-team-touchpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants