-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [PQ-257] add ebollo configuration to checkout policy apim #2668
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@infantesimone @pietro-tota this change allows MDB project to use |
@@ -11,6 +11,11 @@ | |||
<value>WISP_REDIRECT</value> | |||
</set-header> | |||
</when> | |||
<when condition="@(context.Subscription != null && context.Subscription.Id.ToLower().Equals("ebollo"))"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to use otherwise
, if there are exceptions or particular clients we will specify them. eBollo
on ecommerce
is tracked as CHECKOUT_CART
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@infantesimone as agreed the when
block has been replaced with otherwise
, there's no need to distinguish between ebollo
payments and any other ones coming from EC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me but just one consideration:
this way we are not distinguishing ebollo
transactions from EC carts transactions into monitoring dashboards (Kibana) nor b.e. side (payment methods, calculate fees, close payment, etc).
eCommerce side those transactions will be undistinguishable from an EC POST carts initiated ones.
My doubt here is if we have to trace those transactions differently for future ad hoc requirements/differentiations from the EC POST carts initiated transactions
cc @pagopa/pagopa-team-touchpoint
…hub.com/pagopa/pagopa-infra into PQ-257-ebollo-client-id-checkout-policy
List of changes
Configured
ebollo
x-client-id
on checkout apim policy.Motivation and context
This change is necessary to properly manage the invocations coming from
ebollo
client toPOST /carts
api.Type of changes
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)