Make the Tofino spec files independent of the generated IR. #5063
Conversation
fruffy
force-pushed
the
fruffy/tofino_specs
branch
2 times, most recently
from
e1813de to
8aae242
Compare
ir/inode.h
Outdated
| return result; | ||
| } | ||
|
|
||
| DECLARE_TYPEINFO(INode); |
There was a problem hiding this comment.
@asl I have a question on the RTTI macros. I am trying to factor out some classes to avoid pulling in the entire IR code. Unfortunately, for IDeclaration and INode macros like DECLARE_TYPEINFO_WITH_TYPEID(INode, NodeKind::INode); require pulling in ir/ir-tree-macros.h which is generated.
Is there a way to avoid this while still being correct?
There was a problem hiding this comment.
Well, the typeid's should be unique. It is part of gen-tree-macro.h. The location is a bit weird, but it was emitted there exactly in order not to pull the whole IR header. It could be even split into separate .h file if gen-tree-macro.h is undesired.
There was a problem hiding this comment.
Yeah, gen-tree-macro depends on the generator which is a little unpleasant. Although the code there is less complex than what is being put into ir-generated.h.
You effectively run into #5013.
Maybe there is a way to depend on gen-tree or just the rtti enum.
There was a problem hiding this comment.
Well, one way to do this is to split enum into "static" and "generated" parts. Static would be for all classes not autogenerated (INode, IDeclaration, Vector), etc. and everything else will be outside the scope.
tools/ir-generator/irclass.cpp
Outdated
| << "#include \"ir/vector.h\" // IWYU pragma: keep\n" | ||
| << "#include \"lib/ordered_map.h\" // IWYU pragma: keep\n" | ||
| << std::endl | ||
| << "namespace P4 {\n" | ||
| << std::endl | ||
| << "class JSONLoader;\n" | ||
| << "using NodeFactoryFn = IR::Node*(*)(JSONLoader&);\n" | ||
| << "using NodeFactoryFn = IR::INode*(*)(JSONLoader&);\n" |
There was a problem hiding this comment.
it looks a bit weird. After all, interface is a property of the object, there is no way to "materialize" pure interface w/o underlying object. But factory produces definite objects, not abstract interfaces, so should be Node here...
fruffy
force-pushed
the
fruffy/tofino_specs
branch
2 times, most recently
from
cb4309d to
71eb3a4
Compare
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
force-pushed
the
fruffy/tofino_specs
branch
from
71eb3a4 to
4449f61
Compare
This makes it possible to depend on these files without pulling in the entire compiler. The advantages of this separation is a mid end that does not depend on the Tofino back end and the ability of other tools (primarily P4Testgen) to link into certain Tofino files.