Make the json loader and parser independent from the generated ir files. #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
run-ubuntu18
fruffy
force-pushed
the
fruffy/json_parser_cleanup
branch
2 times, most recently
from
69ddfc5 to
2bf40dc
Compare
Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
force-pushed
the
fruffy/json_parser_cleanup
branch
from
2bf40dc to
d132111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yak shaving to untangle the Tofino dependency blob. This PR makes it possible to link against the json loader and generator without pulling in the entire IR.