Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect annotation parsing in Tofino. #5051

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix incorrect annotation parsing in Tofino. #5051

merged 1 commit into from
Dec 5, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Dec 4, 2024 •
edited
Loading

Fix a bug uncovered in #5038. We were not checking whether the annotation needs to be parsed.

@fruffy fruffy added the tofino Topics related to the Tofino switch and back end. label Dec 4, 2024
@fruffy fruffy force-pushed the fruffy/tofino branch 3 times, most recently from 75f8b67 to dbc99ec Compare December 5, 2024 00:25
@fruffy fruffy marked this pull request as ready for review December 5, 2024 01:32
@fruffy
Fix incorrect annotation parsing in Tofino.
18bfccb 
Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy requested a review from asl December 5, 2024 01:34
@fruffy fruffy added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit d9af61c Dec 5, 2024
19 checks passed
@fruffy fruffy deleted the fruffy/tofino branch December 5, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asl asl asl approved these changes

Assignees
No one assigned
Labels
tofino Topics related to the Tofino switch and back end.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @asl