Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PCHs for IR headers #5033

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Enable PCHs for IR headers #5033

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93dbc25
Enable PCHs for IR headers
asl Nov 25, 2024
5caf134
Clarify that PCHs are not compatible with Unity builds due to PIC / P…
asl Nov 25, 2024
a898fb5
Properly forward declare Transform
asl Nov 25, 2024
e19c08b
Try to disable PIE
asl Nov 26, 2024
a15f764
Disable PCHs by default
asl Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify that PCHs are not compatible with Unity builds due to PIC / P… 
…IE always enable (do we really need it though?)

Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
  • Loading branch information
@asl
asl committed Dec 3, 2024
commit 5caf134fa831b4d9d1ca23b31dd170ffe942b818
4 changes: 3 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,11 @@ if(ENABLE_UNIFIED_COMPILATION)
set(CMAKE_UNITY_BUILD ON)
endif()

# If unity builds are enabled, choose an aggressive batch size.
if (CMAKE_UNITY_BUILD)
# If unity builds are enabled, choose an aggressive batch size.
set(CMAKE_UNITY_BUILD_BATCH_SIZE 10 CACHE UNINITIALIZED "Set the unity build batch size.")
# Disable PCHs as they conflict with PIC settings above
set(ENABLE_PCH OFF)
endif ()

# Set the required options for a (mostly) static release build.
Expand Down