search for includes in share/p4c #4978
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
the
core
ChrisDodd
force-pushed
the
cdodd-includepath
branch
from
c943476 to
6d723c0
Compare
fruffy
approved these changes
Nov 1, 2024
| @@ -395,10 +395,13 @@ bool ParserOptions::searchForIncludePath(const char *&includePathOut, | |||
| } | |||
|
|
|||
| std::vector<const char *> *ParserOptions::process(int argc, char *const argv[]) { | |||
| searchForIncludePath(p4includePath, {"p4include"_cs, "../p4include"_cs, "../../p4include"_cs}, | |||
| searchForIncludePath(p4includePath, | |||
| {"p4include"_cs, "../p4include"_cs, "../../p4include"_cs, | |||
There was a problem hiding this comment.
Maybe create a virtual function that returns this list? Then the list can be overridden by other back ends.
ChrisDodd
force-pushed
the
cdodd-includepath
branch
from
6d723c0 to
53e89e9
Compare
Signed-off-by: Chris Dodd <cdodd@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally the compiler is run via the p4c driver which sets up the include path properly, but sometimes one wants to run the executable directly. If it is installed in a
bindirectory somewhere, the standard include files will likely be inshare/p4c/p4include, so this change looks there as well as where it was looking.