Add lower and upper string operations to stringify header. #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are |
vlstill
reviewed
Sep 30, 2024
lib/stringify.h
Outdated
|
|
||
| /// Convert a string to upper case. This is not safe for non-ASCII strings. | ||
| /// Performs the up operation in place. | ||
| void upperinPlace(std::string &s); |
There was a problem hiding this comment.
Suggested change
| void upperinPlace(std::string &s); | |
| void upperInPlace(std::string &s); |
lib/stringify.h
Outdated
| @@ -123,6 +123,21 @@ cstring toString(const void *value); | |||
|
|
|||
| char DigitToChar(int digit); | |||
|
|
|||
| /// Convert a string to lower case. This is not safe for non-ASCII strings. | |||
| /// Performs the lowering operation in place. | |||
| void lowerinPlace(std::string &s); | |||
There was a problem hiding this comment.
Suggested change
| void lowerinPlace(std::string &s); | |
| void lowerInPlace(std::string &s); |
lib/stringify.h
Outdated
| /// Performs the lowering operation in place. | ||
| void lowerinPlace(std::string &s); | ||
|
|
||
| /// Convert a string to lower case. This is not safe for non-ASCII strings. |
There was a problem hiding this comment.
It is (probably) "safe" in a sense it will not crash. It is just not what might be expected (e.g. locale-aware UTF-8 lowercase).
I always forget we have Abseil now.. I will use these instead of transform then |
fruffy
force-pushed
the
fruffy/string_utils
branch
2 times, most recently
from
0a134e4 to
53ea8d7
Compare
Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
force-pushed
the
fruffy/string_utils
branch
from
53ea8d7 to
217816f
Compare
fruffy
added
the
core
|
The test fails for non-ascii characters. I will wait for C++20, maybe there is something that can be done here then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.