Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4fmt]: attaching comments to IR Nodes #4845

Merged
merged 15 commits into from
Oct 24, 2024
Merged

[P4fmt]: attaching comments to IR Nodes #4845

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b1b41ba
[P4fmt]: attach comments
snapdgn Aug 1, 2024
ecc463b
fix: resolve issue with modifying container during iteration
snapdgn Aug 26, 2024
a29b6db
refactor: rename variables, remove unused headers
snapdgn Aug 26, 2024
a7b3801
doc comments
snapdgn Aug 28, 2024
cfda268
use node's clone-id
snapdgn Aug 29, 2024
ab547c4
rebase & resolve nits
snapdgn Sep 2, 2024
ef82f51
expose IHasSourceInfo for the Comment class
snapdgn Sep 2, 2024
1940838
extract comments from InputSources instead of partial SourceInfo
snapdgn Sep 5, 2024
df3c4b5
remove extraneous method
snapdgn Sep 5, 2024
ff05186
fix missing `toString()` override
snapdgn Sep 5, 2024
9ffa53b
chore: comment fixes & minor refactoring
snapdgn Sep 6, 2024
6113435
refactor `parseProgram` fn
snapdgn Sep 6, 2024
741129e
resolve: nits & suggestions
snapdgn Sep 13, 2024
3114afb
switch to Inspector pass
snapdgn Sep 14, 2024
a3c5c10
take globalCommentMap by ref
snapdgn Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
expose IHasSourceInfo for the Comment class 
Signed-off-by: Nitish <snapdgnn@proton.me>
  • Loading branch information
@snapdgn
snapdgn committed Oct 24, 2024
commit ef82f5157625172e28d3d71c800f147ca737da8d
2 changes: 1 addition & 1 deletion backends/p4fmt/attach.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const IR::Node *Attach::attachCommentsToNode(IR::Node *node, TraversalType ttype
continue;
}

const auto &commentEnd = comment->getEndPosition();
const auto &commentEnd = comment->getSourceInfo().getEnd();

switch (ttype) {
case TraversalType::Preorder:
snapdgn marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
8 changes: 3 additions & 5 deletions lib/source_file.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ struct SourceFileLine {
cstring toString() const;
};

class Comment final : IHasDbPrint {
class Comment final : IHasDbPrint, IHasSourceInfo {
private:
SourceInfo srcInfo;
bool singleLine;
Expand All @@ -274,10 +274,8 @@ class Comment final : IHasDbPrint {
if (!singleLine) out << "*/";
}

/// Retrieve the beginning of the source position associated with this comment.
[[nodiscard]] const SourcePosition &getStartPosition() const { return srcInfo.getStart(); }
/// Retrieve the end of the source position associated with this comment.
[[nodiscard]] const SourcePosition &getEndPosition() const { return srcInfo.getEnd(); }
/// Retrieve the Source position associated with this Comment.
snapdgn marked this conversation as resolved.
Show resolved Hide resolved
[[nodiscard]] SourceInfo getSourceInfo() const override { return srcInfo; }
};

/**
Expand Down