Skip to content

Commit

Permalink
Pass to get rid of action_run() calls
Browse files Browse the repository at this point in the history
- introduce new metadata set in the actions of the table

Signed-off-by: Chris Dodd <cdodd@nvidia.com>
  • Loading branch information
ChrisDodd committed Dec 10, 2024
1 parent 650af7e commit 7976cfe
Show file tree
Hide file tree
Showing 8 changed files with 305 additions and 54 deletions.
1 change: 1 addition & 0 deletions backends/p4test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ set (P4TEST_SRCS
midend.cpp
)
set (P4TEST_HDRS
p4test.h
midend.h
)

Expand Down
6 changes: 4 additions & 2 deletions backends/p4test/midend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ limitations under the License.
#include "midend/complexComparison.h"
#include "midend/copyStructures.h"
#include "midend/def_use.h"
#include "midend/eliminateActionRun.h"
#include "midend/eliminateInvalidHeaders.h"
#include "midend/eliminateNewtype.h"
#include "midend/eliminateSerEnums.h"
Expand Down Expand Up @@ -76,7 +77,7 @@ class SkipControls : public P4::ActionSynthesisPolicy {
}
};

MidEnd::MidEnd(CompilerOptions &options, std::ostream *outStream) {
MidEnd::MidEnd(P4TestOptions &options, std::ostream *outStream) {
bool isv1 = options.langVersion == CompilerOptions::FrontendVersion::P4_14;
refMap.setIsV1(isv1);
auto evaluator = new P4::EvaluatorPass(&refMap, &typeMap);
Expand Down Expand Up @@ -125,7 +126,8 @@ MidEnd::MidEnd(CompilerOptions &options, std::ostream *outStream) {
new P4::SimplifyControlFlow(&typeMap),
new P4::CompileTimeOperations(),
new P4::TableHit(&typeMap),
new P4::EliminateSwitch(&typeMap),
!options.preferSwitch ? new P4::EliminateSwitch(&typeMap) : nullptr,
options.preferSwitch ? new P4::ElimActionRun() : nullptr,
new P4::ResolveReferences(&refMap),
new P4::TypeChecking(&refMap, &typeMap, true), // update types before ComputeDefUse
new PassRepeated({
Expand Down
3 changes: 2 additions & 1 deletion backends/p4test/midend.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ limitations under the License.
#include "frontends/common/options.h"
#include "frontends/p4/evaluator/evaluator.h"
#include "ir/ir.h"
#include "p4test.h"

namespace P4::P4Test {

Expand All @@ -32,7 +33,7 @@ class MidEnd : public PassManager {
IR::ToplevelBlock *toplevel = nullptr;

void addDebugHook(DebugHook hook) { hooks.push_back(hook); }
explicit MidEnd(CompilerOptions &options, std::ostream *outStream = nullptr);
explicit MidEnd(P4TestOptions &options, std::ostream *outStream = nullptr);
IR::ToplevelBlock *process(const IR::P4Program *&program) {
addDebugHooks(hooks, true);
program = program->apply(*this);
Expand Down
103 changes: 52 additions & 51 deletions backends/p4test/p4test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

#include "p4test.h"

#include <fstream> // IWYU pragma: keep
#include <iostream>

Expand All @@ -35,57 +37,56 @@ limitations under the License.
#include "lib/nullstream.h"
#include "midend.h"

using namespace P4;

class P4TestOptions : public CompilerOptions {
public:
bool parseOnly = false;
bool validateOnly = false;
bool loadIRFromJson = false;
P4TestOptions() {
registerOption(
"--listMidendPasses", nullptr,
[this](const char *) {
listMidendPasses = true;
loadIRFromJson = false;
P4Test::MidEnd MidEnd(*this, outStream);
exit(0);
return false;
},
"[p4test] Lists exact name of all midend passes.\n");
registerOption(
"--parse-only", nullptr,
[this](const char *) {
parseOnly = true;
return true;
},
"only parse the P4 input, without any further processing");
registerOption(
"--validate", nullptr,
[this](const char *) {
validateOnly = true;
return true;
},
"Validate the P4 input, running just the front-end");
registerOption(
"--fromJSON", "file",
[this](const char *arg) {
loadIRFromJson = true;
file = arg;
return true;
},
"read previously dumped json instead of P4 source code");
registerOption(
"--turn-off-logn", nullptr,
[](const char *) {
::P4::Log::Detail::enableLoggingGlobally = false;
return true;
},
"Turn off LOGN() statements in the compiler.\n"
"Use '@__debug' annotation to enable LOGN on "
"the annotated P4 object within the source code.\n");
}
};
P4TestOptions::P4TestOptions() {
registerOption(
"--listMidendPasses", nullptr,
[this](const char *) {
listMidendPasses = true;
loadIRFromJson = false;
P4Test::MidEnd MidEnd(*this, outStream);
exit(0);
return false;
},
"[p4test] Lists exact name of all midend passes.\n");
registerOption(
"--parse-only", nullptr,
[this](const char *) {
parseOnly = true;
return true;
},
"only parse the P4 input, without any further processing");
registerOption(
"--validate", nullptr,
[this](const char *) {
validateOnly = true;
return true;
},
"Validate the P4 input, running just the front-end");
registerOption(
"--fromJSON", "file",
[this](const char *arg) {
loadIRFromJson = true;
file = arg;
return true;
},
"read previously dumped json instead of P4 source code");
registerOption(
"--turn-off-logn", nullptr,
[](const char *) {
::P4::Log::Detail::enableLoggingGlobally = false;
return true;
},
"Turn off LOGN() statements in the compiler.\n"
"Use '@__debug' annotation to enable LOGN on "
"the annotated P4 object within the source code.\n");
registerOption(
"--preferSwitch", nullptr,
[this](const char *) {
preferSwitch = true;
return true;
},
"use passes that convert to switch instead eliminating them");
}

using P4TestContext = P4CContextWithOptions<P4TestOptions>;

Expand Down
33 changes: 33 additions & 0 deletions backends/p4test/p4test.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/*
Copyright 2013-present Barefoot Networks, Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

#ifndef BACKENDS_P4TEST_P4TEST_H_
#define BACKENDS_P4TEST_P4TEST_H_

#include "frontends/common/options.h"

using namespace P4;

class P4TestOptions : public CompilerOptions {
public:
bool parseOnly = false;
bool validateOnly = false;
bool loadIRFromJson = false;
bool preferSwitch = false;
P4TestOptions();
};

#endif /* BACKENDS_P4TEST_P4TEST_H_ */
2 changes: 2 additions & 0 deletions midend/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ set (MIDEND_SRCS
copyStructures.cpp
coverage.cpp
def_use.cpp
eliminateActionRun.cpp
eliminateInvalidHeaders.cpp
eliminateNewtype.cpp
eliminateSerEnums.cpp
Expand Down Expand Up @@ -74,6 +75,7 @@ set (MIDEND_HDRS
copyStructures.h
coverage.h
def_use.h
eliminateActionRun.h
eliminateInvalidHeaders.h
eliminateNewtype.h
eliminateSerEnums.h
Expand Down
124 changes: 124 additions & 0 deletions midend/eliminateActionRun.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
/*
Copyright 2024 Intel Corp.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

#include "eliminateActionRun.h"

#include "frontends/p4/methodInstance.h"

namespace P4 {

void ElimActionRun::ActionTableUse::postorder(const IR::Member *mem) {
if (mem->member != "action_run") return;
auto *mce = mem->expr->to<IR::MethodCallExpression>();
if (!mce) return;
auto *mi = MethodInstance::resolve(mce, this);
auto *tbl = mi->object->to<IR::P4Table>();
if (!tbl) return;
LOG3("found: " << mem);
auto [it, inserted] = self.actionRunTables.emplace(tbl->name, tbl);
if (!inserted) {
LOG3(" (additional apply() of table)");
return;
}
auto *info = &it->second;
IR::IndexedVector<IR::Declaration_ID> tags;
for (auto *ale : tbl->getActionList()->actionList) {
cstring name = ale->getName();
BUG_CHECK(!self.actionsToModify.count(name),
"action %s used in multiple tables (%s and %s) -- LocalizeActions must be run "
"before ElimActionRun",
name, self.actionsToModify.at(name)->tbl->name, tbl->name);
self.actionsToModify[name] = info;
cstring tag = self.nameGen.newName(tbl->name + "_" + name);
info->actions.emplace(name, tag);
tags.push_back(new IR::Declaration_ID(tag));
LOG4(" action " << name << " [" << ale->expression << "] -> " << tag);
}
info->action_tags =
new IR::Type_Enum(self.nameGen.newName(tbl->name + "_action_run_t"), std::move(tags));
info->action_run = new IR::Declaration_Variable(self.nameGen.newName(tbl->name + "_action_run"),
new IR::Type_Name(info->action_tags->name));
}

const IR::Expression *ElimActionRun::RewriteActionRun::postorder(IR::Member *mem) {
if (mem->member != "action_run") return mem;
auto *mce = mem->expr->to<IR::MethodCallExpression>();
if (!mce) return mem;
auto *mi = MethodInstance::resolve(mce, this);
auto *tbl = mi->object->to<IR::P4Table>();
if (!tbl) return mem;
auto &info = self.actionRunTables.at(tbl->name);
auto *parent = findContext<IR::Statement>();
BUG_CHECK(parent && parent->is<IR::SwitchStatement>(), "action_run not in switch");
auto &pps = self.prepend_statement[parent];
if (!pps) pps = new IR::Vector<IR::StatOrDecl>;
pps->push_back(new IR::MethodCallStatement(mce));
self.add_to_control.push_back(info.action_run);
return new IR::PathExpression(new IR::Type_Name(info.action_tags->name), info.action_run->name);
}

const IR::P4Action *ElimActionRun::RewriteActionRun::preorder(IR::P4Action *act) {
auto *info = get(self.actionsToModify, act->name);
if (!info) return act;
auto *body = act->body->clone();
auto *tag_type = new IR::Type_Name(info->action_tags->name);

body->components.insert(
body->components.begin(),
new IR::AssignmentStatement(
new IR::PathExpression(tag_type->clone(), info->action_run->name),
new IR::Member(new IR::TypeNameExpression(tag_type), info->actions.at(act->name))));
act->body = body;
return act;
}

const IR::SwitchCase *ElimActionRun::RewriteActionRun::postorder(IR::SwitchCase *swCase) {
auto *swtch = getParent<IR::SwitchStatement>();
BUG_CHECK(swtch, "case not in switch");
if (!self.prepend_statement.count(swtch)) return swCase;
if (swCase->label->is<IR::DefaultExpression>()) return swCase;
auto *pe = swCase->label->to<IR::PathExpression>();
BUG_CHECK(pe, "case label is not an action name");
auto *info = self.actionsToModify.at(pe->path->name);
auto *tag_type = new IR::Type_Name(info->action_tags->name);
swCase->label =
new IR::Member(new IR::TypeNameExpression(tag_type), info->actions.at(pe->path->name));
return swCase;
}

const IR::Node *ElimActionRun::RewriteActionRun::postorder(IR::Statement *stmt) {
auto *pps = get(self.prepend_statement, stmt);
if (!pps) return stmt;
pps->push_back(stmt);
self.prepend_statement.erase(stmt);
return pps;
}

const IR::P4Control *ElimActionRun::RewriteActionRun::postorder(IR::P4Control *ctrl) {
BUG_CHECK(self.prepend_statement.empty(), "orphan action_run in control %s", ctrl->name);
ctrl->controlLocals.prepend(self.add_to_control);
if (!self.add_to_control.empty()) LOG4(ctrl);
self.add_to_control.clear();
return ctrl;
}

const IR::P4Program *ElimActionRun::RewriteActionRun::postorder(IR::P4Program *prog) {
auto front = prog->objects.begin();
for (auto &[_, info] : self.actionRunTables) prog->objects.insert(front, info.action_tags);
return prog;
}

} // namespace P4
Loading

0 comments on commit 7976cfe

Please sign in to comment.