Skip to content

Commit

Permalink
Xfail updates.
Browse files Browse the repository at this point in the history 
Signed-off-by: fruffy <fruffy@nyu.edu>
  • Loading branch information
@fruffy
fruffy committed Dec 5, 2024
1 parent 602ef1e commit 3a126c4
Show file tree
Hide file tree
Showing 7 changed files with 14,233 additions and 173 deletions.
8 changes: 4 additions & 4 deletions backends/p4tools/modules/testgen/targets/tofino/test/P4Tests.cmake
View file
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ p4tools_add_tests(
TARGET "tofino" ARCH "tna" CTEST_P4C_ARGS "${P416INCLUDES} --disable-power-check --disable-parse-depth-limit" RUN_STF TEST_ARGS "-D__TARGET_TOFINO__=1 --test-backend STF --port-ranges 0:63 ${EXTRA_OPTS}"
)

# include(${CMAKE_CURRENT_LIST_DIR}/TofinoXfail.cmake)
include(${CMAKE_CURRENT_LIST_DIR}/TofinoXfail.cmake)

set (P4TOOLS_TESTGEN_TOFINO_T2NA_STF ${P4TOOLS_TESTGEN_TOFINO_T2NA})
list(REMOVE_ITEM P4TOOLS_TESTGEN_TOFINO_T2NA_STF
Expand All @@ -181,7 +181,7 @@ p4tools_add_tests(
TAG "testgen-tofino2" DRIVER ${P4TESTGEN_DRIVER}
TARGET "tofino2" ARCH "t2na" CTEST_P4C_ARGS "${P416INCLUDES} --disable-power-check --disable-parse-depth-limit" RUN_STF TEST_ARGS "-D__TARGET_TOFINO__=2 --test-backend STF --port-ranges 8:71 ${EXTRA_OPTS}"
)
# include(${CMAKE_CURRENT_LIST_DIR}/Tofino2Xfail.cmake)
include(${CMAKE_CURRENT_LIST_DIR}/Tofino2Xfail.cmake)

# # # ##########################################################################
# PTF TESTS
Expand All @@ -192,14 +192,14 @@ p4tools_add_tests(
TAG "testgen-tofino-ptf" DRIVER ${P4TESTGEN_DRIVER}
TARGET "tofino" ARCH "tna" CTEST_P4C_ARGS "${P416INCLUDES} --disable-power-check --disable-parse-depth-limit" RUN_PTF TEST_ARGS "-D__TARGET_TOFINO__=1 -I${P4C_SOURCE_DIR}/p4_16/includes --test-backend PTF --port-ranges 0:15 ${EXTRA_OPTS}"
)
# include(${CMAKE_CURRENT_LIST_DIR}/TofinoPTFXfail.cmake)
include(${CMAKE_CURRENT_LIST_DIR}/TofinoPTFXfail.cmake)

p4tools_add_tests(
TESTS "${P4TOOLS_TESTGEN_TOFINO_T2NA}"
TAG "testgen-tofino2-ptf" DRIVER ${P4TESTGEN_DRIVER}
TARGET "tofino2" ARCH "t2na" CTEST_P4C_ARGS "${P416INCLUDES} --disable-power-check --disable-parse-depth-limit" RUN_PTF TEST_ARGS "-D__TARGET_TOFINO__=2 --test-backend PTF --port-ranges 8:15 ${EXTRA_OPTS}"
)
# include(${CMAKE_CURRENT_LIST_DIR}/Tofino2PTFXfail.cmake)
include(${CMAKE_CURRENT_LIST_DIR}/Tofino2PTFXfail.cmake)


# # # ##########################################################################
Expand Down
36 changes: 18 additions & 18 deletions backends/p4tools/modules/testgen/targets/tofino/test/Tofino2PTFXfail.cmake
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,37 +7,37 @@
p4tools_add_xfail_reason(
"testgen-tofino2-ptf"
"Unknown or unimplemented extern method:"
mirror.p4
# mirror.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2-ptf"
"Unknown or unimplemented extern method: emit"
# Resubmit.emit
tna_resubmit.p4
empty_header_stack.p4
# tna_resubmit.p4
# empty_header_stack.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2-ptf"
"Unknown or unimplemented extern method: set"
parser_counter_10.p4
parser_counter_7.p4
parser_counter_stack_1.p4
# parser_counter_10.p4
# parser_counter_7.p4
# parser_counter_stack_1.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2-ptf"
"Unknown or unimplemented extern method: enqueue"
# RegisterAction.enqueue
t2na_fifo.p4
# t2na_fifo.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2-ptf"
"Unknown or unimplemented extern method: execute"
# MinMaxAction.execute
t2na_ghost.p4
# t2na_ghost.p4
)

p4tools_add_xfail_reason(
Expand All @@ -64,7 +64,7 @@ p4tools_add_xfail_reason(
p4tools_add_xfail_reason(
"testgen-tofino2-ptf"
"is trying to match on a tainted key set"
parser_multi_write_checksum_verify_5.p4
# parser_multi_write_checksum_verify_5.p4
)

p4tools_add_xfail_reason(
Expand All @@ -73,22 +73,22 @@ p4tools_add_xfail_reason(
# Our packet model is incomplete.
# We do not model the case where we append metadata but do not parse it.
# tna_register.p4
tna_alpmV2.p4
# tna_alpmV2.p4
# Most likely a compiler bug
tna_extract_emit_3.p4
tna_action_profile_1.p4
# tna_extract_emit_3.p4
# tna_action_profile_1.p4
# Meter is not fully implemented.
large_counter_meter.p4
# large_counter_meter.p4
# TODO:
tna_multicast.p4
# tna_multicast.p4
tna_simple_switch.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2-ptf"
"exceeded the maximum number of permitted guard violations for this run"
t2na_emulation.p4
too_many_pov_bits.p4
# t2na_emulation.p4
# too_many_pov_bits.p4
)

p4tools_add_xfail_reason(
Expand All @@ -110,7 +110,7 @@ p4tools_add_xfail_reason(
p4tools_add_xfail_reason(
"testgen-tofino2-ptf"
"Match type dleft_hash not implemented for table keys"
hwlrn.p4
# hwlrn.p4
)

# This is out of our control.
Expand All @@ -122,7 +122,7 @@ p4tools_add_xfail_reason(
p4tools_add_xfail_reason(
"testgen-tofino2-ptf"
"Failed to subscribe to server at %s"
varbit_four_options.p4
# varbit_four_options.p4
)

# These are compilation bugs we have no control over.
Expand Down
62 changes: 31 additions & 31 deletions backends/p4tools/modules/testgen/targets/tofino/test/Tofino2Xfail.cmake
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,39 +7,39 @@
p4tools_add_xfail_reason(
"testgen-tofino2"
"Match type range not implemented"
tna_range_match.p4
tna_field_slice.p4
t2na_uni_dim_scale_base.p4
varbit_four_options.p4
# tna_range_match.p4
# tna_field_slice.p4
# t2na_uni_dim_scale_base.p4
# varbit_four_options.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2"
"Match type dleft_hash not implemented"
hwlrn.p4
# hwlrn.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2"
"Unknown or unimplemented extern method:"
mirror.p4
t2na_ghost.p4
# mirror.p4
# t2na_ghost.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2"
"Unknown or unimplemented extern method: emit"
# Resubmit.emit
tna_resubmit.p4
empty_header_stack.p4
# tna_resubmit.p4
# empty_header_stack.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2"
"Unknown or unimplemented extern method: set"
parser_counter_10.p4
parser_counter_7.p4
parser_counter_stack_1.p4
# parser_counter_10.p4
# parser_counter_7.p4
# parser_counter_stack_1.p4
)

p4tools_add_xfail_reason(
Expand All @@ -62,7 +62,7 @@ p4tools_add_xfail_reason(
"testgen-tofino2"
"Unknown or unimplemented extern method: enqueue"
# RegisterAction.enqueue
t2na_fifo.p4
# t2na_fifo.p4
)

p4tools_add_xfail_reason(
Expand All @@ -83,26 +83,26 @@ p4tools_add_xfail_reason(
p4tools_add_xfail_reason(
"testgen-tofino2"
"unhandled stage table type"
tna_proxy_hash.p4
# tna_proxy_hash.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2"
"Table .* has no stage tables"
bfrt_alpm_perf.p4
tna_lpm_match.p4
tna_alpm.p4
tna_alpmV2.p4
tna_ipv4_alpm.p4
tna_ipv6_alpm.p4
tna_ternary_match.p4
# bfrt_alpm_perf.p4
# tna_lpm_match.p4
# tna_alpm.p4
# tna_alpmV2.p4
# tna_ipv4_alpm.p4
# tna_ipv6_alpm.p4
# tna_ternary_match.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2"
"error -2 thrown"
tna_meter_bytecount_adjust.p4
tna_meter_lpf_wred.p4
# tna_meter_bytecount_adjust.p4
# tna_meter_lpf_wred.p4
)

p4tools_add_xfail_reason(
Expand All @@ -114,14 +114,14 @@ p4tools_add_xfail_reason(
"testgen-tofino2"
"is trying to match on a tainted key set"
switch_tofino2_y1_mod.p4
parser_multi_write_checksum_verify_5.p4
# parser_multi_write_checksum_verify_5.p4
)

# Looks like a compiler/test_harness bug
p4tools_add_xfail_reason(
"testgen-tofino2"
"Clot slices must be used in order"
tna_extract_emit_3.p4
# tna_extract_emit_3.p4
)

p4tools_add_xfail_reason(
Expand All @@ -132,14 +132,14 @@ p4tools_add_xfail_reason(
p4tools_add_xfail_reason(
"testgen-tofino2"
"must specify match fields before action"
tna_checksum.p4
# tna_checksum.p4
)

p4tools_add_xfail_reason(
"testgen-tofino2"
"exceeded the maximum number of permitted guard violations for this run"
t2na_emulation.p4
too_many_pov_bits.p4
# t2na_emulation.p4
# too_many_pov_bits.p4
)

p4tools_add_xfail_reason(
Expand All @@ -152,7 +152,7 @@ p4tools_add_xfail_reason(
p4tools_add_xfail_reason(
"testgen-tofino2"
"1 expected packet on port .* not seen"
tna_multicast.p4
# tna_multicast.p4
)

p4tools_add_xfail_reason(
Expand All @@ -172,7 +172,7 @@ p4tools_add_xfail_reason(
# We do not model the case where we append metadata but do not parse it.
# tna_register.p4
# Meter is not fully implemented.
large_counter_meter.p4
# large_counter_meter.p4
# TODO
)

Expand All @@ -185,7 +185,7 @@ p4tools_add_xfail_reason(
p4tools_add_xfail_reason(
"testgen-tofino2"
"duplicate value for .*"
misc1.p4
# misc1.p4
)

# These are tests that currently fail.
Expand Down
Loading

0 comments on commit 3a126c4

Please sign in to comment.