Camera clipping #1217
Camera clipping #1217
Conversation
HifiExperiments
added
needs CR
interface/src/Application.cpp
Outdated
| _maxOctreePPS(_maxOctreePacketsPerSecond.get()), | ||
| // Camera | ||
| _fieldOfView("fieldOfView", DEFAULT_FIELD_OF_VIEW_DEGREES), | ||
| _cameraClippingEnabled("cameraClippingEnabled", false) |
There was a problem hiding this comment.
the option defaults to false currently, but I can change that if we want
|
Avatar entities seem to also cause the camera to clip. This makes it to where clothing causes the camera to clip in some situations. This might not be ideal. |
great point, I changed it to only clip against domain and local entities, not avatar entities |
|
I just tested it and it desktop mode clipping works pretty well. The problems I noticed is that it clips with local entities created by Create App, like for example zone icons. Also small entities cause clipping, making the camera move too much so maybe it would be good to ignore entities below certain size relative to avatar size? |
|
hm good points. the picking system doesn’t currently allow specifying sizes like that, but maybe it’s something we could add in the future? as for local entities, I thought there would be more cases where we would want to collide with local entities. made clipping should just be disabled completely in create mode though? |
|
I would think we would want to clip with local entities too. We can probably just force Create App to disable camera clipping when the create app window is opened and return it to the previous setting when it closes. |
I think it's indeed best choice currently. When Create App is not open the current version works really well, and is a massive ux improvement in my opinion. |
|
I wanted to test it but where can I activate the function? |
|
@Krzeszny if I remember correctly, one place you can toggle it is the Graphics settings |
HifiExperiments
force-pushed
the
cameraClip
branch
from
51ac9bf to
64c62e8
Compare
|
I've updated this to turn off while in Create mode, and return to the saved state when you exit Create. however, since it depends on #939, it'll have to wait until that one is merged |
|
I just tested the newest version, and it works perfectly with Create App now :) |
ksuprynowicz
added
QA approved
HifiExperiments
force-pushed
the
cameraClip
branch
from
64c62e8 to
18c7320
Compare
|
since the application PR needs more work, I've separated this out so it's good for review now |
|
I tested it, works perfectly now :) |
Closes #299
this adds an optional (single, for now) ray pick to the 3rd person (and selfie cam) camera to make sure the camera doesn't clip through entities
Funding
This project is funded through NGI0 Entrust, a fund established by NLnet with financial support from the European Commission's Next Generation Internet program. Learn more at the NLnet project page.