Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests using bench brick to generate pings. #398

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

outscale-fne
Copy link
Contributor

No description provided.

Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
@outscale-mgo
Copy link
Contributor

Can one of the admins verify this patch?

@outscale-fne outscale-fne changed the title Add "real" tests using bench brick, testing the ping output. Add tests using bench brick to generate pings. Feb 19, 2020
tests/functions.sh Outdated Show resolved Hide resolved
tests/functions.sh Outdated Show resolved Hide resolved
tests/functions.sh Outdated Show resolved Hide resolved
tests/functions.sh Outdated Show resolved Hide resolved
@outscale-fne
Copy link
Contributor Author

@outscale-toa changes done!

@outscale-fne outscale-fne force-pushed the fnouaille branch 3 times, most recently from 40add99 to b2fcb27 Compare February 26, 2020 13:06
Copy link
Contributor

@outscale-mgo outscale-mgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So The test seems ok 2 me, 2 note though:

@@ -21,7 +21,7 @@ RETURN_CODE=0
function return_result {
clean_all
if [ $RETURN_CODE == 0 ]; then
echo $CUR_TEST 'SUCESS !!!'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, can you move this to another commit please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

de suite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants