Merge pull request twisted#1176 from twisted/9687-review-me

Author: glyph Reviewer: moshez Fixes: ticket:9687 Improve the pull request template to make it clearer to new contributors what they should be doing.
oshixingxing · Sep 19, 2019 · 783f03a · 783f03a
2 parents 049eb52 + 5b4c994
commit 783f03a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE
@@ -1,12 +1,13 @@
-## Remove this paragraph
+## Remove this section
 
-Please have a look at our developer documentation before submitting your Pull Request.
+Please have a look at [our developer documentation](https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch) before submitting your Pull Request.
 
-https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch
+Please note that the trac ticket, news fragment, and review submission portions of this process apply to *all* pull requests, no matter how small; if you don't do them, it's likely that nobody will even notice your PR needs a review.
 
 ## Contributor Checklist:
 
-* [ ] There is an associated ticket in Trac. Create a new one at https://twistedmatrix.com/trac/newticket
+* [ ] The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/<!-- Create a new one at https://twistedmatrix.com/trac/newticket and replace this comment with the ticket number. -->
 * [ ] The changes pass minimal style checks (see: https://twistedmatrix.com/trac/wiki/TwistedDevelopment#GettingYourPatchAccepted )
 * [ ] I have created a newsfragment in src/twisted/newsfragments/ (see: https://twistedmatrix.com/trac/wiki/ReviewProcess#Newsfiles )
 * [ ] I have updated the automated tests.
+* [ ] I have submitted the associated Trac ticket for review by adding the word `review` to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.
diff --git a/src/twisted/newsfragments/9687.misc b/src/twisted/newsfragments/9687.misc