Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Does not conform to RFC 7230 and has been ignored #1033

Open
niejian opened this issue Dec 9, 2022 · 8 comments · May be fixed by #1034
Open

[Bug] Does not conform to RFC 7230 and has been ignored #1033

niejian opened this issue Dec 9, 2022 · 8 comments · May be fixed by #1034
Labels
in: hippo4j-server type: bug Something isn't working

Comments

@niejian
Copy link

niejian commented Dec 9, 2022

BUG 报告

在开始报告错误之前，请确保认真查看了以下步骤：

请在提交问题之前回答这些问题，谢谢。

你使用了哪个项目？hippo4j config 还是 hippo4j server?

hippo4j server

你使用了哪个版本？

1.5.0-SNAPSHOT

预期行为

实际行为

原因分析（如果可以）

问题重现步骤

轮训，ClientWorker#checkUpdateTpIds
image
返回400

用于重现此问题的示例代码（例如 GitHub 链接）
@niejian niejian linked a pull request Dec 9, 2022 that will close this issue
Open
@pirme
Copy link
Member

pirme commented Dec 9, 2022

什么场景下会出现这种问题呢

@niejian
Copy link
Author

niejian commented Dec 9, 2022

什么场景下会出现这种问题呢
我用的alibaba dubbo，server模式。客户端启动后就会提示

@niejian
Copy link
Author

niejian commented Dec 9, 2022

客户端提示400
image
**服务端 **

java.lang.IllegalArgumentException: The HTTP header line [client-version0x0d] does not conform to RFC 7230 and has been ignored.
	at org.apache.coyote.http11.Http11InputBuffer.skipLine(Http11InputBuffer.java:1020) ~[tomcat-embed-core-9.0.37.jar:9.0.37]
	at org.apache.coyote.http11.Http11InputBuffer.parseHeader(Http11InputBuffer.java:872) ~[tomcat-embed-core-9.0.37.jar:9.0.37]
	at org.apache.coyote.http11.Http11InputBuffer.parseHeaders(Http11InputBuffer.java:594) ~[tomcat-embed-core-9.0.37.jar:9.0.37]
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:283) ~[tomcat-embed-core-9.0.37.jar:9.0.37]
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) [tomcat-embed-core-9.0.37.jar:9.0.37]
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868) [tomcat-embed-core-9.0.37.jar:9.0.37]
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1589) [tomcat-embed-core-9.0.37.jar:9.0.37]
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-embed-core-9.0.37.jar:9.0.37]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_161]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_161]
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-embed-core-9.0.37.jar:9.0.37]
	at java.lang.Thread.run(Thread.java:748) [na:1.8.0_161]

@niejian
Copy link
Author

niejian commented Dec 9, 2022

加上我提的哪个pr就没问题
1.4.3 不报错

@pirme pirme added this to the 1.5.0 milestone Dec 9, 2022
@pirme
Copy link
Member

pirme commented Dec 9, 2022

如果 1.4.3 可以的话，我觉得咱们应该找下具体的原因，而不是以堆积的方式去修复遗留问题。你觉得呢

@niejian
Copy link
Author

niejian commented Dec 9, 2022 •
edited
Loading

如果 1.4.3 可以的话，我觉得咱们应该找下具体的原因，而不是以堆积的方式去修复遗留问题。你觉得呢

  • 1.4.3没问题是因为问题：alibaba dubbo 无法获取线程池运行状态 #966
  • 我这边客户端使用的springboot版本是2.3.12.RELEASE，server端版本是2.3.2..REALEASE；如果不加在server端堆配置的话，那就得要求客户端去主动适配服务端版本，这样是不是会有局限性？

@pirme
Copy link
Member

pirme commented Dec 10, 2022

不好意思，我没明白本 Issue 和 #966 有什么关系？

@niejian
Copy link
Author

niejian commented Dec 13, 2022

不好意思，我没明白本 Issue 和 #966 有什么关系？

因为 #966 的问题， 所以就不会有轮训这回事了；而本issue就是因为轮训发送http 请求发生的错误

@magestacks magestacks removed this from the 1.5.0 milestone Mar 16, 2023
@yanrongzhen yanrongzhen added type: bug Something isn't working and removed type: optimize labels Sep 1, 2023
@yanrongzhen yanrongzhen changed the title does not conform to RFC 7230 and has been ignored [Bug] Does not conform to RFC 7230 and has been ignored Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: hippo4j-server type: bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@niejian @pirme @magestacks @yanrongzhen