Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confighttp] Make ToServerOption into a sealed interface #9479

Open
mx-psi opened this issue Feb 6, 2024 · 1 comment
Open

[confighttp] Make ToServerOption into a sealed interface #9479

mx-psi opened this issue Feb 6, 2024 · 1 comment
Labels
area:config

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 6, 2024

ToServerOption has underlying type func(*privateStruct). I think we should make it into an interface because of:

  1. consistency with other modules in this repository
  2. allows creating a hierarchy of options (e.g. we could have some Options that work both confighttp and configrpc by creating in the future a shared package for both)

To solve this issue I think we should:

  • Add guidance to CONTRIBUTING.md on how to add options
  • Make confighttp follow this guidance
@mx-psi mx-psi added release:required-for-ga Must be resolved before GA release area:config labels Feb 6, 2024
@TylerHelmuth TylerHelmuth mentioned this issue Mar 21, 2024
Closed
@mx-psi mx-psi moved this to Todo in Collector: v1 Apr 18, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Jul 17, 2024

I don't think this needs to be in Collector 1.0, we can make this change independently

@mx-psi mx-psi removed this from Collector: v1 Jul 17, 2024
@mx-psi mx-psi removed the release:required-for-ga Must be resolved before GA release label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:config
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mx-psi