Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trusting only a set of certificate hashes #10523

Open
sinkingpoint opened this issue Jul 3, 2024 · 0 comments
Open

Support trusting only a set of certificate hashes #10523

sinkingpoint opened this issue Jul 3, 2024 · 0 comments
Labels
area:config auth Authentication related enhancement New feature or request

Comments

@sinkingpoint
Copy link

Is your feature request related to a problem? Please describe.
When using publicly signed client certificates, we need some way to limit the keys that we trust (otherwise any publicly signed cert would work). This is generally achieved by specifying a set of SHA(1|256) fingerprints to trust (e.g. https://www.syslog-ng.com/technical-documents/doc/syslog-ng-open-source-edition/3.16/administration-guide/56#tls-options-trusted-keys ).

Describe the solution you'd like
I'd like to introduce a new option into configtls, TrustedKeys []string, which would introduce a VerifyPeerCertificate callback to the TLS config that rejects the TLS connection if the key hash is not in the list of trusted keys

Describe alternatives you've considered
We could use privately signed certs, but publicly signed client certs is a relatively common occurance

@mx-psi mx-psi added area:config auth Authentication related enhancement New feature or request labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config auth Authentication related enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants