Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confighttp] Make the compression level configurable #10467

Open
rnishtala-sumo opened this issue Jun 26, 2024 · 6 comments
Open

[confighttp] Make the compression level configurable #10467

rnishtala-sumo opened this issue Jun 26, 2024 · 6 comments
Assignees
Labels
area:config enhancement New feature or request

Comments

@rnishtala-sumo
Copy link
Contributor

Current compression algorithms seem to support multiple compression levels. These levels determine the speed and efficiency of the compression algorithm.

Lower compression levels provide faster speed but larger file sizes. Compression levels could be 3, 5, 7 or 11. Level 3 seems to be the default across multiple compression algorithms. It could benefit a user to give them the option to save on AWS egress costs by configuring a higher compression level with a tradeoff on processing speed.

Example configuration could looks like below:

exporter:
  otlphttp:
    endpoint: otelcol2:55690
    auth:
      authenticator: some-authenticator-extension
    tls:
      ca_file: ca.pem
      cert_file: cert.pem
      key_file: key.pem
    headers:
      test1: "value1"
      "test 2": "value 2"
    compression
       type: zstd
       level: 7
    cookies:
      enabled: true
@mx-psi mx-psi added enhancement New feature or request area:config labels Jun 26, 2024
@rnishtala-sumo
Copy link
Contributor Author

I like the idea of configuring this as a single string

exporter:
  otlphttp:
    endpoint: otelcol2:55690
    auth:
      authenticator: some-authenticator-extension
    tls:
      ca_file: ca.pem
      cert_file: cert.pem
      key_file: key.pem
    headers:
      test1: "value1"
      "test 2": "value 2"
    compression: zstd/7
    cookies:
      enabled: true

@wasim-nihal
Copy link

Hi @mx-psi /@rnishtala-sumo , is this open for contribution?

@rnishtala-sumo
Copy link
Contributor Author

@wasim-nihal yes, please proceed if this issue is of interest to you. I can assist with the PR review.

@rnishtala-sumo
Copy link
Contributor Author

rnishtala-sumo commented Aug 21, 2024

@mx-psi @dmitryax if there's no one working on this, could this issue be assigned to me?

@mx-psi
Copy link
Member

mx-psi commented Aug 22, 2024

Assigned!

@rnishtala-sumo
Copy link
Contributor Author

@dmitryax @mx-psi I've raised a PR for this issue. Would appreciate your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants