Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace a Vec<T> with Rc<[T]> #275

Closed
wants to merge 3 commits into from
Closed

replace a Vec<T> with Rc<[T]> #275

wants to merge 3 commits into from

Conversation

asukaminato0721
Copy link
Collaborator

ref https://www.youtube.com/watch?v=A4cKi7PTJSs

not sure the final result though

@asukaminato0721 asukaminato0721 changed the title try it replace some Vec with Arc<[T]> Jan 25, 2025
@asukaminato0721 asukaminato0721 changed the title replace some Vec with Arc<[T]> replace some Vec<T> with Arc<[T]> Jan 25, 2025
@asukaminato0721 asukaminato0721 changed the title replace some Vec<T> with Arc<[T]> replace some Vec<T> with Rc<[T]> Jan 25, 2025
@asukaminato0721 asukaminato0721 changed the title replace some Vec<T> with Rc<[T]> replace a Vec<T> with Rc<[T]> Jan 25, 2025
L-M-Sherlock
L-M-Sherlock approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-M-Sherlock
Copy link
Member

No improvement found:

Before:

Processed 107:   1%|▎                                | 100/10000 [02:38<4:44:28,  1.72s/it]

After:

Processed 107:   1%|▎                                | 100/10000 [02:38<4:49:32,  1.75s/it]

@asukaminato0721 asukaminato0721 deleted the pref-use-arc-slice branch January 26, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-M-Sherlock L-M-Sherlock L-M-Sherlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asukaminato0721 @L-M-Sherlock