Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtenv: Logging can be confusing when creating submodules dynamically #1168

Open
torokati44 opened this issue May 29, 2024 · 2 comments
Open

qtenv: Logging can be confusing when creating submodules dynamically #1168

torokati44 opened this issue May 29, 2024 · 2 comments
Labels
in runtime / Qtenv new New issue that has not been yet acknowledged
Milestone
under review

Comments

@torokati44
Copy link
Member

torokati44 commented May 29, 2024 •
edited
Loading

Platform

  • OMNeT++ version: 6.0.3
  • OS: Fedora 40

See for example this piece of code:

void Tester2::handleMessage(cMessage *msg)
{
    EV_INFO << "Creating Dummy module." << std::endl;
    cModuleType *moduleType = cModuleType::get("Dummy");
    moduleType->createScheduleInit("dummy", this);
    EV_INFO << "Dummy module created." << std::endl;
    delete msg;
}

Results in this in the log inspector:

image

Expand for the text of the screenshot 
INFO (Tester2)LogFormattingTest2.tester: Creating Dummy module.
INFO (Tester2)LogFormattingTest2.tester: Message from the Dummy constructor.
Initializing module LogFormattingTest2.tester.dummy, stage 0
INFO (Dummy)LogFormattingTest2.tester.dummy: Message from the Dummy initialize.
INFO (Tester2)LogFormattingTest2.tester: Dummy module created.

The problem is that the last line is not delineated from the banner of the submodule initialization, but it now again belongs to the Event #3 block.
@torokati44 torokati44 added new New issue that has not been yet acknowledged in runtime / Qtenv labels May 29, 2024
@torokati44
Copy link
Member Author

What do you think the output should look like in this case, @levy?
Should the banner of the event that creates the submodule be repeated?

@levy
Copy link
Contributor

levy commented May 29, 2024

Probably something like that, but it must also be different from the first event heading, so people doesn't get confused.

@rhornig rhornig added this to the 6.1 milestone May 29, 2024
@rhornig rhornig modified the milestones: 6.1, under review Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in runtime / Qtenv new New issue that has not been yet acknowledged
Projects
None yet
Milestone
under review
Development

No branches or pull requests
3 participants
@rhornig @levy @torokati44