Add tests for arp

omardawed · Mar 31, 2015 · b5c6188 · b5c6188
1 parent 1447afe
commit b5c6188
Show file tree

Hide file tree

Showing 2 changed files with 85 additions and 9 deletions.
diff --git a/decode/arp.js b/decode/arp.js
@@ -3,15 +3,15 @@ var IPv4Addr = require("./ipv4_addr");
 
 function Arp(emitter) {
     this.emitter = emitter;
-    this.htype = null;
-    this.ptype = null;
-    this.heln = null;
-    this.plen = null;
-    this.operation = null;
-    this.sender_ha = null;
-    this.sender_pa = null;
-    this.target_ha = null;
-    this.target_pa = null;
+    this.htype = undefined;
+    this.ptype = undefined;
+    this.hlen = undefined;
+    this.plen = undefined;
+    this.operation = undefined;
+    this.sender_ha = undefined;
+    this.sender_pa = undefined;
+    this.target_ha = undefined;
+    this.target_pa = undefined;
 }
 
 // http://en.wikipedia.org/wiki/Address_Resolution_Protocol

diff --git a/spec/decode/arp.spec.js b/spec/decode/arp.spec.js
@@ -0,0 +1,76 @@
+var Arp = require("../../decode/arp");
+var events = require("events");
+var shouldBehaveLikeADecoder = require("./decode").shouldBehaveLikeADecoder;
+require("should");
+
+describe("Arp", function(){
+  beforeEach(function () {
+    this.eventEmitter = new events.EventEmitter();
+    this.instance = new Arp(this.eventEmitter);
+    this.example = new Buffer("0001" +
+                              "0800060400010007" +
+                              "0daff454454cd801" +
+                              "000000000000454c" +
+                              "dfd5", "hex");
+  });
+
+  describe("#decode()", function(){
+    shouldBehaveLikeADecoder("arp", true);
+
+    it("sets #htype to the hardware type", function () {
+      this.instance.decode(this.example, 0);
+      this.instance.should.have.property("htype", 1); // Ethernet
+    });
+
+    it("sets #ptype to the protocol type", function () {
+      this.instance.decode(this.example, 0);
+      this.instance.should.have.property("ptype", 0x0800); // IP
+    });
+
+    it("sets #hlen to the hardware size", function () {
+      this.instance.decode(this.example, 0);
+      this.instance.should.have.property("hlen", 6);
+    });
+
+    it("sets #plen to the protocol size", function () {
+      this.instance.decode(this.example, 0);
+      this.instance.should.have.property("plen", 4);
+    });
+
+    it("sets #operation to the operation code", function () {
+      this.instance.decode(this.example, 0);
+      this.instance.should.have.property("operation", 1);
+    });
+
+    it("sets #sender_ha to the sender's MAC", function () {
+      this.instance.decode(this.example, 0);
+      this.instance.sender_ha.should.have.property("addr", [0x00, 0x07, 0x0d, 0xaf, 0xf4, 0x54]);
+    });
+
+    it("sets #sender_pa to the sender's protocol address", function () {
+      this.instance.decode(this.example, 0);
+      this.instance.sender_pa.should.have.property("addr", [69, 76, 216, 1]);
+    });
+
+    it("sets #target_ha to the target's MAC", function () {
+      this.instance.decode(this.example, 0);
+      this.instance.target_ha.should.have.property("addr", [0x00, 0x00, 0x00, 0x00, 0x00, 0x00]);
+    });
+
+    it("sets #target_pa to the sender's protocol address", function () {
+      this.instance.decode(this.example, 0);
+      this.instance.target_pa.should.have.property("addr", [69, 76, 223, 213]);
+    });
+  });
+
+  describe("#toString()", function(){
+    it("is a function", function(){
+      this.instance.toString.should.be.type("function");
+    });
+
+    it("returns a value like request sender 00:07:0d:af:f4:54 69.76.216.1 target 00:00:00:00:00:00 69.76.223.213", function() {
+      this.instance.decode(this.example, 0);
+      this.instance.toString().should.be.exactly("request sender 00:07:0d:af:f4:54 69.76.216.1 target 00:00:00:00:00:00 69.76.223.213");
+    });
+  });
+});