fix: only add to history of different #8197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the last item in history is the same as the one being added, skip it. this reduces the number of history entries. the behaviour is similar to how most shells maintain history
mxyng
force-pushed
the
mxyng/cmd-history
branch
from
2951ebf to
77e7e12
Compare
mxyng
commented
Dec 21, 2024
Comment on lines
-119
to
-124
| if i.History.Pos > 0 { | ||
| if i.History.Pos == i.History.Size() { | ||
| currentLineBuf = []rune(buf.String()) | ||
| } | ||
| buf.Replace([]rune(i.History.Prev())) | ||
| } |
There was a problem hiding this comment.
This and the block below are unnecessary since History.Prev() and History.Next() should return the correct line content; the logic is duplicated between here and readline/history.go and it seems more appropriate for it to live there. The only benefit of having this conditional is omitting the call to Replace() which doesn't seem worth it for the added complexity
|
|
||
| f, err := os.OpenFile(path, os.O_CREATE|os.O_RDONLY, 0o600) | ||
| if err != nil { | ||
| if errors.Is(err, os.ErrNotExist) { |
There was a problem hiding this comment.
This shouldn't be possible with O_CREATE
mxyng
force-pushed
the
mxyng/cmd-history
branch
2 times, most recently
from
8b0bf9e to
7570003
Compare
mxyng
force-pushed
the
mxyng/cmd-history
branch
from
7570003 to
a1d90e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the last item in history is the same as the one being added, skip it. this reduces the number of history entries. the behaviour is similar to how most shells maintain history