Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Sourcer traits for serving source #2301

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: Implement Sourcer traits for serving source #2301

wants to merge 9 commits into from

Conversation

BulkBeing
Copy link
Contributor

closes: #2281

@BulkBeing
/v1/process/async publish works
3a45e5f 
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing
Unit tests for configurations
198fe00 
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing
Remove jetstream related config options
94dcddd 
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing
Remove unused constants
ae42c29 
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@vigith
Copy link
Member

vigith commented Dec 24, 2024

please resolve conflicts?

@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.59091% with 235 lines in your changes missing coverage. Please review.

Project coverage is 66.77%. Comparing base (faa27a6) to head (ca8cdeb).

Files with missing lines Patch % Lines
rust/serving/src/source.rs 0.00% 117 Missing ⚠️
rust/numaflow-core/src/source/serving.rs 0.00% 47 Missing ⚠️
rust/serving/src/app.rs 69.69% 20 Missing ⚠️
rust/numaflow-core/src/shared/create_components.rs 0.00% 11 Missing ⚠️
rust/serving/src/lib.rs 0.00% 9 Missing ⚠️
rust/numaflow-core/src/source.rs 0.00% 7 Missing ⚠️
rust/serving/src/config.rs 78.78% 7 Missing ⚠️
rust/numaflow-core/src/config/components.rs 0.00% 6 Missing ⚠️
rust/serving/src/pipeline.rs 0.00% 5 Missing ⚠️
rust/serving/src/app/jetstream_proxy.rs 97.74% 3 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
- Coverage   67.02%   66.77%   -0.25%     
==========================================
  Files         349      351       +2     
  Lines       44961    45004      +43     
==========================================
- Hits        30133    30050      -83     
- Misses      13752    13876     +124     
- Partials     1076     1078       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BulkBeing
Modify serving to be a built-in source
e20b022 
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing
Remove duplicate code, make serving a built-in source
f548609 
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing
Unit tests for Serving endpoints
ca8cdeb 
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy Awaiting requested review from whynowy whynowy will be requested when the pull request is marked ready for review whynowy is a code owner

@vigith vigith Awaiting requested review from vigith vigith will be requested when the pull request is marked ready for review vigith is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Sourcer traits to support serving
2 participants
@BulkBeing @vigith