Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monovertex run_forwarder unit test improvement #2214

Open
KeranYang opened this issue Nov 8, 2024 · 0 comments
Open

monovertex run_forwarder unit test improvement #2214

KeranYang opened this issue Nov 8, 2024 · 0 comments
Labels
area/mono-vertex Mono Vertex testing Testing and CI

Comments

@KeranYang
Copy link
Member

the run_forwarder unit test doesn't respect the test server info object. I can change it to minimum required numaflow version to 2.0.0, test still passes. Plus, if I change the real(non-testing) minimum required rust version to 0.3.0, it breaks the run_forwarder test. Ideally a production config change shouldn't break an existing unit test unless the unit test is to test the config.

@KeranYang KeranYang added the area/mono-vertex Mono Vertex label Nov 8, 2024
@vigith vigith added the testing Testing and CI label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mono-vertex Mono Vertex testing Testing and CI
Projects
None yet
Development

No branches or pull requests

2 participants