Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Configuration files with different extensions and APP_INSTANCE not loaded in the right order #746

Open
sgaestel opened this issue Nov 15, 2023 · 2 comments
Open

[BUG] Configuration files with different extensions and APP_INSTANCE not loaded in the right order #746

sgaestel opened this issue Nov 15, 2023 · 2 comments

Comments

@sgaestel
Copy link

Describe the bug
I having config files with different extensions, and some defined using an APP_INSTANCE, the loading order is not the expected one.

Let's say I have following files:

development-instance.json
development-instance.yml
development.yml

They are currently loaded as:

development-instance.json
development.yml
development-instance.yml

Expected behavior
From the documentation (and checking at the extensions loading order), I would expect files to be loaded in following order:

development.yml
development-instance.json
development-instance.yml

Please tell us about your environment:

  • node-config version: 1.31.0
  • node-version: 16.20.2
@lorenwest
Copy link
Collaborator

You're right that the expected and documented behavior is to load in this order

development.yml
development-instance.json
development-instance.yml

It would be a bug if it loaded development-instance.json before development.yml.

Would you or a community member be willing to validate this bug by writing a failing test?

sgaestel pushed a commit to sgaestel/node-config that referenced this issue Nov 16, 2023
Fix node-configGH-746 - Loading config files order with APP_INSTANCE
d42baeb
@sgaestel
Copy link
Author

Submitted a PR with both the test and the fix here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lorenwest @sgaestel