You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: for support questions, please use StackOverflow and tag your question with node-config. This repository's issues are reserved for feature requests and bug reports.
Before submitting a bug report, please search the issue tracker the wiki first. Many issues have already been discussed.
If there's too much work to treat the hostname as case-insensitive in the code-base, it would at least be better in my opinion to normalize to lowercase or uppercase and add some information to the documentation to remove the ambiguity.
There is another issue related to this question but it was closed almost 6 years ago - #235
Please tell us about your environment:
node-config version: 3.3.1
node-version: 12
Other information
(e.g. are you using an environment besides Node.js?)
The text was updated successfully, but these errors were encountered:
I recommend this be resolved by standardizing the hostnames to lowercase and only loading the lowercase version of the hostname file. This could be breaking change for some.
node-config already checks a huge number of file variations, and supporting both myhost.json and MYHOST.json would only add to complexity and confusion in the future. And let's not talk about MyHost.json.
I like the idea of standardizing on lower-case, but I'm closing this as stale due to lack of community interest to submit a PR for this or even comment on the issue in the last 3 years.
Note: for support questions, please use StackOverflow and tag your question with
node-config
. This repository's issues are reserved for feature requests and bug reports.Before submitting a bug report, please search the issue tracker the wiki first. Many issues have already been discussed.
The wiki is located at: https://github.com/lorenwest/node-config/wiki
I'm submitting a ...
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem:
There are two issues here that lead to confusing behavior.
hostname
value is treated as case-sensitive in the file look up even on a case-insensitive file system.hostname
can produce a different cased value depending on what tool is being used.For example:
What is the expected behavior?
This RFC indicates hostnames are case-insensitive https://tools.ietf.org/html/rfc4343
If there's too much work to treat the hostname as case-insensitive in the code-base, it would at least be better in my opinion to normalize to lowercase or uppercase and add some information to the documentation to remove the ambiguity.
There is another issue related to this question but it was closed almost 6 years ago - #235
Please tell us about your environment:
Other information
(e.g. are you using an environment besides Node.js?)
The text was updated successfully, but these errors were encountered: