Rename function to reverseRange #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function was renamed to reverseRange as it better describes its purpose compared to the previous name reverseLine.
ccoVeille
reviewed
Jan 4, 2025
| @@ -42,6 +41,7 @@ require ( | |||
| github.com/spf13/cast v1.7.1 // indirect | |||
| github.com/subosito/gotenv v1.6.0 // indirect | |||
| go.uber.org/multierr v1.11.0 // indirect | |||
| golang.org/x/exp v0.0.0-20250103183323-7d7fa50e5329 // indirect | |||
There was a problem hiding this comment.
I'm surprised to see a go.mod change when you are renaming a method
There was a problem hiding this comment.
I'm sorry. I'll be careful.
There was a problem hiding this comment.
It's not a matter of being careful. I was simply curious why it changed
And yes, someone looking for commit history about a bug/change cause could be confused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was renamed to reverseRange as it better describes its purpose compared to the previous name reverseLine.