Adds in the ability to set a non-networked parent entity for networked NAF entities #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow networked entities to become childeren of a non-networked parent * update basic example with commennts * require # to be in param * add platform example and update to use syncData.parent field * quality updates * quality * fix css rule * Address spelling issues * Add a visible description to the non-networked parent example * Update instantiation of nonNetworkedParent --------- Co-authored-by: Akul Gupta <akulgupta2000@gmail.com>
|
Thanks @Agupta00 and @travaglinit I'll take a closer look soon. I just released 0.12.0 with some fixes related to the video sharing. I'll integrate this PR in a way or another for 0.13.0. @travaglinit can you update in your PR the versions for aframe, aframe-extras, environment? see #447 for the versions to use. |
@vincentfretin done! Example in this PR has been updated to use specified versions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fork of the changes made in this PR #401 with the addition of bug fixes. This change adds in the ability to set a non-networked parent on networked entities, as described in detail in the PR above.
Addresses issue #400