Add more tests. Address issue w/ perlbrew 5.16.0

nebulous · Feb 20, 2015 · 0a76259 · 0a76259
1 parent 074ba56
commit 0a76259
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/lib/XML/Simple/Minded.pm b/lib/XML/Simple/Minded.pm
@@ -13,6 +13,7 @@ has _xml => (is=>'rw', default=>sub{''});
 has _struc => (is=>'rw', default=>sub{{}});
 has _root => (is=>'rw');
 has _parent => (is=>'rw');
+has _depth => (is=>'ro', default=>0);
 
 sub FOREIGNBUILDARGS {
 	return (force_array=>1, keep_root=>1, key_attr=>[]);
@@ -34,10 +35,13 @@ sub BUILDARGS {
 sub BUILD {
 	my $self = shift;
 	$self->_struc($self->XMLin($self->_xml)) if $self->_xml;
-	#my $clone = { %{$self->_struc||{} } };
 	$self->_struc(Hash::AsObject->new($self->_struc));
 }
 
+sub DESTROY {
+	my $self = shift;
+}
+
 sub TO_JSON {
 	my $self = shift;
 	return $self->_struc();
@@ -93,20 +97,21 @@ sub AUTOLOAD {
 	my $self = shift;
 	my $search = $AUTOLOAD;
 	$search =~ s/XML::Simple::Minded:://;
+	die 'Suspicious recursion' if $self->_depth>99;
 
 	sub haso {
 		my ($in, $parent) = @_;
 		my $ref = ref($in);
 
 		if ($ref eq 'ARRAY') {
-			return &haso($in->[0]) if scalar(@$in) == 1;
+			return &haso($in->[0], $parent) if scalar(@$in) == 1;
 			foreach my $e (@$in) {
 				$e = &haso($e, $parent);
 			}
 			return $in;
 		}
 		if ($ref eq 'HASH' or $ref eq 'Hash::AsObject') {
-			return XML::Simple::Minded->new(_struc=>$in, _parent=>$parent);
+			return XML::Simple::Minded->new(_struc=>$in, _parent=>$parent, _depth=>$parent ? ($parent->_depth+1) : 0);
 		}
 		return $in;
 	};
@@ -121,7 +126,7 @@ sub AUTOLOAD {
 	}
 	my $res = $self->_struc->$search();
 	if (!defined($res)) {
-		return XML::Simple::Minded->new(_root=>$search, _parent=>$self);
+		return XML::Simple::Minded->new(_root=>$search, _parent=>$self, _depth=>99);
 	}
 	return &haso($res,$self);
 }

diff --git a/t/01-xml-simple-minded.t b/t/01-xml-simple-minded.t
@@ -6,13 +6,17 @@ BEGIN {
 	use_ok('XML::Simple::Minded');
 }
 
-my $xml = XML::Simple::Minded->new("$FindBin::Bin/systems17.raw");
+my $xml = XML::Simple::Minded->new("<this that=\"option\">valueforthis</this>");
 isa_ok($xml, 'XML::Simple::Minded');
+is($xml->this->content,'valueforthis', 'contents');
+is($xml->this->that,'option','attributes');
+$xml = undef;
 
-is($xml->system->config->mode,'auto');
+$xml = XML::Simple::Minded->new("$FindBin::Bin/systems17.raw");
+is($xml->system->config->mode,'auto','XML parses');
 
 $xml->system->config->testitem(['test value']);
-is($xml->system->config->testitem,'test value');
+is($xml->system->config->testitem,'test value','New values added');
 
 my $xml_string = $xml."";
 ok($xml_string =~ m/^<\?xml/,'xml stringifies definition');

diff --git a/t/system-post.t b/t/system-post.t
@@ -1,4 +1,4 @@
-use Test::More;
+use Test::More tests=>9;
 use Test::Mojo;
 
 # Include application