convert empty tags to self-closing. fixes #66

nebulous · Dec 20, 2018 · 08de698 · 08de698
1 parent b604ab8
commit 08de698
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/lib/XML/Simple/Minded.pm b/lib/XML/Simple/Minded.pm
@@ -88,7 +88,13 @@ use overload '""' => sub {
 		1;
 	}
 	my $sx = XML::Simple::Minded::Sorter->new( keep_root=>$self->_root ? 1 : 0, xml_decl=>'<?xml version="1.0" encoding="UTF-8"?>', no_indent=>1 );
-	return $sx->XMLout($rstruc);
+	my $xml_string = $sx->XMLout($rstruc);
+	$xml_string =~ s/<(\w+)><\/(\w+)>/&selfclose($1,$2)/gse;
+	sub selfclose {
+		my ($one, $two) = @_;
+		return ($one eq $two) ? "<$one/>" : "<$one></$two>"
+	}
+	return $xml_string;
 };
 
 our $AUTOLOAD;

diff --git a/t/01-xml-simple-minded.t b/t/01-xml-simple-minded.t
@@ -6,10 +6,13 @@ BEGIN {
 	use_ok('XML::Simple::Minded');
 }
 
-my $xml = XML::Simple::Minded->new("<this that=\"option\">valueforthis</this>");
+my $xml = XML::Simple::Minded->new("<this that=\"option\">valueforthis<empty></empty></this>");
 isa_ok($xml, 'XML::Simple::Minded');
 is($xml->this->content,'valueforthis', 'contents');
 is($xml->this->that,'option','attributes');
+my $xml_string = $xml.'';
+ok($xml_string =~ m/<empty\/>/, 'empty tags are self-closing');
+ok($xml_string !~ m/<\/empty>/, 'self-closing tags are clean');
 $xml = undef;
 
 $xml = XML::Simple::Minded->new("$FindBin::Bin/systems17.raw");
@@ -18,7 +21,7 @@ is($xml->system->config->mode,'auto','XML parses');
 $xml->system->config->testitem(['test value']);
 is($xml->system->config->testitem,'test value','New values added');
 
-my $xml_string = $xml."";
+$xml_string = $xml."";
 ok($xml_string =~ m/^<\?xml/,'xml stringifies definition');
 ok($xml_string =~ m/<\/system>$/,'xml stringifies system');
 ok($xml_string =~ m/<testitem>test value<\/testitem>/,'new test item added');