Fixing missing assignment of MP3 Codec when specified, in conjucture with the Node backend #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ec, when the MP3 codec is selected in conjuncture with the Node Backend.
…ode backend is selected. Validate with unit test.
xsdg
requested changes
Jun 2, 2024
…o align with PEP-0257
xsdg
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: There was an issue that the MP3 Codec was not assigned if it was assigned when using the Node Backend. If no codec, or any other codec was set, this would be set back to the MP3 codec.
Related Issue: #468
Work done:
Nodeand the Codec toMP3as specified in the issue.Nodebackend. The print out is still specific to any other codec, explaining that it has been reset to MP3, as the node backend only supports MP3.