Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault progress not based on dynamic (card) set data #531

Open
geneC opened this issue Apr 18, 2020 · 1 comment
Open

Vault progress not based on dynamic (card) set data #531

geneC opened this issue Apr 18, 2020 · 1 comment

Comments

@geneC
Copy link

geneC commented Apr 18, 2020

python-mtga:source/mtga/set_data/dynamic.py allows the set data to be based on querying the JSON files in the MTG Arena install. This is used by the main pane for mtgatracker:electron/index.html for showing the contents of a deck.

This dynamic data is not being properly used for the vault in multiple locations. mtgatracker:electron/index.html and mtgatracker:electron/collection.html shows percent progress only within the static set_data. Vault Treasure ( mtgatracker:electron/collection.html ) only shows (very) old sets under "Booster Packs". Vault Completion ( mtgatracker:electron/collection.html plus mtgatracker:electron/collectionRenderer.js ) only shows a selection of the sets.

This might be multiple related issues and warrant splitting.

@geneC
Copy link
Author

geneC commented Apr 18, 2020

Vault Recent ( mtgatracker:electron/collection.html ) does not show the names of cards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant